Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vue-cli-plugin-electron-builderを2.0.0 -> 3.0.0.-alpha4 にした影響の調査 #6

Closed
so-c opened this issue Jul 15, 2022 · 4 comments · Fixed by #17
Closed

vue-cli-plugin-electron-builderを2.0.0 -> 3.0.0.-alpha4 にした影響の調査 #6

so-c opened this issue Jul 15, 2022 · 4 comments · Fixed by #17
Labels
bug Something isn't working question Further information is requested

Comments

@so-c
Copy link
Owner

so-c commented Jul 15, 2022

vue-cli-plugin-electron-builderを3.0.0-alpha.4に上げると素直に導入できそうだがbuildへの影響を調べきれていない

Originally posted by @so-c in #1 (comment)
@so-c so-c changed the title vue-cli-plugin-electron-builderの2.0.0 -> 3.0.0.-alpha4 にした影響の調査 vue-cli-plugin-electron-builderを2.0.0 -> 3.0.0.-alpha4 にした影響の調査 Jul 15, 2022
@so-c so-c added the question Further information is requested label Jul 15, 2022
@so-c
Copy link
Owner Author

so-c commented Jul 17, 2022 •
edited
Loading

npm install <alias>@npm:<name>
npm-install | npm Docs テスト時だけ 3.0.0.-alpha4にする？

テスト対象とリリース対象でビルドが違うのも気になるが、経過措置的にはありか？

This was referenced Jul 17, 2022
Open
Merged
@so-c
Copy link
Owner Author

so-c commented Jul 19, 2022

npm run electron:build_pnever
で

file source doesn't exist from=D:\a\voicevox\voicevox_engine\run.dist
要調査

@so-c so-c added the bug Something isn't working label Jul 19, 2022
@so-c
Copy link
Owner Author

so-c commented Jul 19, 2022 •
edited
Loading

https://github.com/VOICEVOX/voicevox/blob/062fd93e55f6c0b744ba00899c782b364ca71f6c/vue.config.js#L6

テストコードではdotenv.config()でお茶を濁したけれどここかな？

so-c pushed a commit that referenced this issue Jul 19, 2022
#6 electron-builder の非互換見落とし
817a0e0
This was referenced Jul 19, 2022
Closed
Merged
@so-c so-c linked a pull request Jul 19, 2022 that will close this issue
so-c#6 electron-builder の非互換見落とし #17
Merged
@so-c so-c closed this as completed in #17 Jul 19, 2022
so-c pushed a commit that referenced this issue Jul 19, 2022
#6 electron-builder の非互換見落とし
c7160fc
@so-c
Copy link
Owner Author

so-c commented Jul 19, 2022

リリースノートに記載の非互換見落とし

takana-v pushed a commit to VOICEVOX/voicevox that referenced this issue Jul 20, 2022
E2Eテスト（Playwright）の導入 (#863)
7e27b08 
* #1 PlayElectronアプリのインスタンス取得、タイトルのアサートを追加

* eslintの自動修正

* compare vue cli mode.

* #4 モンキーパッチなのでbackground.tsのエンジン連携部分をテストできていないがとりあえずデータ準備を超えられた。

* #7 package.jsonから削除。READMEのテスト実施方法も変更（暫定）。

* #7 cypressコンフィグとplaywrightコンフィグに入れ替え

* #7 削除忘れ

* #7 コードフォーマットの類

* #7 .github actionsの設定からCypressのキャッシュフォルダ指定を削除

* #7 package.jsonから削除。READMEのテスト実施方法も変更（暫定）。

* #7 cypressコンフィグとplaywrightコンフィグに入れ替え

* #7 削除忘れ

* #7 コードフォーマットの類

* VOICEVOX#803 test:e2eでE2Eテストを動かせるようにする

* so-c#6 electron-builder の非互換見落とし
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Milestone
No milestone
1 participant
@so-c