Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not swizzle views if screen view autotracking is disabled (close #889) #890

Merged
merged 1 commit into from
May 13, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions Sources/Core/Tracker/Tracker.swift
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,17 @@ class Tracker: NSObject {

var applicationContext = TrackerDefaults.applicationContext

var autotrackScreenViews = TrackerDefaults.autotrackScreenViews
private var _autotrackScreenViews = TrackerDefaults.autotrackScreenViews
var autotrackScreenViews: Bool {
get { return _autotrackScreenViews }
set {
_autotrackScreenViews = newValue
if builderFinished && _autotrackScreenViews {
UIKitScreenViewTracking.setup()
}
}
}


private var _foregroundTimeout = TrackerDefaults.foregroundTimeout
var foregroundTimeout: Int {
Expand Down Expand Up @@ -292,7 +302,9 @@ class Tracker: NSObject {
tracker: self)
}

UIKitScreenViewTracking.setup()
if autotrackScreenViews {
UIKitScreenViewTracking.setup()
}
NotificationCenter.default.addObserver(
self,
selector: #selector(receiveScreenViewNotification(_:)),
Expand Down
Loading