Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not swizzle views if screen view autotracking is disabled (close #889) #890

Merged
merged 1 commit into from
May 13, 2024

Conversation

matus-tomlein
Copy link
Contributor

Issue #889

Conditionally performs UIKit swizzling in order to set up screen view autotracking.

Previously swizzling was done even if autotracking was disabled, this was not necessary and could cause problems in some apps.

This is PR adds a condition to not perform swizzling if autotracking is disabled.

@matus-tomlein matus-tomlein changed the base branch from master to release/6.0.3 May 13, 2024 08:39
Copy link
Contributor

@mscwilson mscwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matus-tomlein matus-tomlein merged commit fb5364c into release/6.0.3 May 13, 2024
24 checks passed
@matus-tomlein matus-tomlein deleted the issue/889-disable_swizzling branch May 13, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants