chore: Merge dev branch to main before v1.0.5 release part 2#3469
Merged
Conversation
## Changes - Adjust sweepers to ignore users and roles used for testing.
Document issue #3421 and how the godebug environment variable can be used to turn off some of the Go features that may not always be compatible with third-party software (like firewalls).
`TestAcc_Grants_To_AccountRole` was failing because of the incompatible data types on the current role: `SNOWFLAKE.CORE."AVG(ARG_T TABLE(FLOAT)):FLOAT"` and `SNOWFLAKE.ACCOUNT_USAGE."TAG_REFERENCES_WITH_LINEAGE(TAG_NAME_INPUT VARCHAR):TABLE:`. Will be addressed soon.
Using the wrong assertion resulted in assertions not being applied at all. 6 tests needed to be fixed: - change the expected value - use fetching the object after changes and not reusing the same one - setup for finalizer tasks reversed
## Changes Some of the tests may fail after adjusting network policies due to their connection with account parameters. This PR was made to check which ones fail after the adjustment and fix them. **Update:** No tests regarding network policy failed after the change, but still some of them did fail and I adjusted them in this pr. - authentication policy changes for show command (it seems the filtering in show command is fixed, but the documentation still needs adjustments) - oauth describe output change (couldn't find any BCR for it) - account acceptance tests failing due to HCL error (multiline string with `"` instead of heredoc)
Continuation to #3406. - Parametrize test client in all assertions and helper functions - Alter the generation of object assertions - Use proper assertions in all tests - Remove deprecated logic - Fix assertions in integration tests - Split object suffix generation to different packages - Fix tests for resource monitors - Fix tests and documentation for not enough privileges when provisioning users
Fix assertions after merges
- Remove the instrumentation of the driver - Remove unused env - Update documentation for logging - Update the GH issue templates
## Changes - Update GitHub Actions and change versions to commit hashes instead of tags (only in non-GitHub actions) - Replace archived ones with new counterparts - Add/Change names of actions for easier navigation (you can compare action names with any other previous pr, e.g. #3428) ## Notes Reviewdog's static code analyzer was uncommented for a bit, but it returned too many errors and needs to be configured before being enabled again (it also analyzed the generated `_gen.go` files).
<!-- Feel free to delete comments as you fill this in --> - Limit TOML file size to 10MB. - Move common OS-related functions to a wrapper package. - Log interactions with OS. <!-- summary of changes --> ## Test Plan <!-- detail ways in which this PR has been tested or needs to be tested --> * [x] acceptance tests <!-- add more below if you think they are relevant --> * [ ] … ## TODO Check the behavior on Windows and adjust the tests.
Remove the additional debug logger; left logs in the places they made sense but using log
Use the pre-created database or create a database with the parameters set (part 1): - the pre-created database not changed yet (it still does not have the parameters) - going alphabetically, last is the databases datasource - generate model builders for database role and database roles - remove file setups when unnecessary - extract acceptance tests nonexisting ids (similarly to integration tests) - add missing `testenvs.EnableAcceptance` and `acc.TestAccPreCheck(t)` - do not add the builders for non-stable datasources Next PRs: - datasources continuation - resources - pre-created database changes
## Changes Introduce environmental secrets for GitHub Actions: - Only set environment for `jira` and `test` environments - `release` and `ok-to-test` require app id and app private key, which will be retrieved later ## Next steps Check if all workflows are working properly
Continuation of #3443. Use the pre-created database or create a database with the parameters set (part 2): - the pre-created database not changed yet (it still does not have the parameters) - going alphabetically, last is the grants datasource - generate model builders for grants datasource - remove file setups when unnecessary (do not migrate the ones with complex multiresource setups) - add missing testenvs.EnableAcceptance and acc.TestAccPreCheck(t) - do not add the builders for non-stable datasources - added a workaround for single attribute datasources - remove unused functions Next PRs: - datasources continuation - resources - pre-created database changes
Continuation of #3443 and #3445. Use the pre-created database or create a database with the parameters set (part 3): - the pre-created database not changed yet (it still does not have the parameters) - going alphabetically, last is the security integrations datasource - generate model builders for NetworkPolicy, ScimSecurityIntegration, Saml2SecurityIntegration, ApiAuthenticationIntegrationWithAuthorizationCodeGrant, ApiAuthenticationIntegrationWithClientCredentials, and ExternalOauthSecurityIntegration resources - generate model builders for NetworkPolicies, ResourceMonitors, Schemas, Secrets, and SecurityIntegrations datasources - remove file setups when unnecessary (do not migrate the ones with complex multiresource setups) - add missing testenvs.EnableAcceptance and acc.TestAccPreCheck(t) - do not add the builders for non-stable datasources - add multiline overrides to OauthIntegrationForCustomClients resource model builder - address issues from the previous review - fix resource name for ExternalOauthSecurityIntegration Next PRs: - datasources continuation (part - last) - resources - pre-created database changes
Continuation of #3443, #3445, and #3448. Use the pre-created database or create a database with the parameters set (part 4): - the pre-created database not changed yet (it still does not have the parameters) - going alphabetically, datasources finished - generate model builders for Streamlit resource - generate model builders for Streamlits, Streams, Tags, Tasks, Users, Views, and Warehouses datasources - remove file setups when unnecessary (do not migrate the ones with complex multiresource setups) - add missing testenvs.EnableAcceptance and acc.TestAccPreCheck(t) - do not add the builders for non-stable datasources - address issues from the previous review - expect AAD_PROVISIONER role at test setup - change default connection helper constructor Next PRs: - resources - pre-created database changes
Small typo fix in a tag resource example. --------- Co-authored-by: Jakub Michalak <jakub.michalak@snowflake.com>
## Changes - Add workflow that validates other workflows. For now, only one rule is applied. - Fix codeql push event
<!-- Feel free to delete comments as you fill this in --> - Add the note about aggressive upgrades and adjust the resource migration guide. - Use title case in the guides. - Add a note about recreating accounts and grace period. - Add a note about pasting logs. - Fix typos. <!-- summary of changes --> ## Test Plan <!-- detail ways in which this PR has been tested or needs to be tested --> * [ ] acceptance tests <!-- add more below if you think they are relevant --> * [ ] … ## References <!-- issues documentation links, etc --> #3390
<!-- Feel free to delete comments as you fill this in --> - Check file permissions on non-Windows platforms. - Add a flag for skipping the verifications. - Adjust the testing pipeline. - Add a note about the lack of permissions checking on Windows. - Add a log entry for loading a specific configuration profile. - Bump crypto pkg. It was flagged by Snyk. - Use new config readers in tests. <!-- summary of changes --> ## Test Plan <!-- detail ways in which this PR has been tested or needs to be tested --> * [ ] acceptance tests <!-- add more below if you think they are relevant --> * [ ] … ## References <!-- issues documentation links, etc --> *
Add snowflakedb migration announcement
…ation (#3453) <!-- Feel free to delete comments as you fill this in --> - Add TOML validation unit tests. - Validate boolean env variables. - Add a link to TOML reference. - Use testhelper in other tests. <!-- summary of changes --> ## Test Plan <!-- detail ways in which this PR has been tested or needs to be tested --> * [ ] acceptance tests <!-- add more below if you think they are relevant --> * [ ] …
<!-- Feel free to delete comments as you fill this in --> Bump provider version in the tracking package. <!-- summary of changes -->
<!-- Feel free to delete comments as you fill this in --> Fix the migration guide after resolving conflicts incorrectly. <!-- summary of changes -->
|
Integration tests cancelled for 4a470611be61891a9fd0a33484e25737b97f2ae9 |
sfc-gh-jcieslak
approved these changes
Mar 24, 2025
sfc-gh-asawicki
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge the new commits to main branch.