Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR partially addresses an issue (#15530) with the signature pad on small screens.
Currently, rendering the signature pad on very small screens (less than 470px it seems like) has two issues:
With this PR the lines are drawn accurately and more clear:
This is achieved by always calling the function that handles high DPI screens and also re-calling it when the screen is re-sized.
But, two things I've noticed is that manually re-sizing the window from large to small or opening/closing the sidebar still exhibit the previous behavior. I'm opening this PR as-is since I think the major problem is solved and I couldn't find an easy solution for the last two issues.
The diff for this looks worse than it is. Showing No Whitespace makes it a lot clearer since I removed an
if
block and de-indented a chunk of code.This builds on the work in #14577
Fixes #15530
Type of change