Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded Signature-pad.js && Fixed Resizing Canvas on mobile #14577

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Apr 9, 2024

Description

upgrades Signature-pad.js from 1.5->4.2.0

In order for the signature pad brush strokes to not look pixlated and for the user to be able to sign across the whole canvas on High DPI screens we need the resizeCanvas() method. This fix applies a media constraint to ignore resizing on 767px width and less. effectively not resizing on an ipad mini and smaller.
Simulator Screen Recording - iPhone 15 Pro Max - 2024-04-09 at 10 35 02

Fixes #14561 [sc-25246]

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@Godmartinz Godmartinz requested a review from snipe as a code owner April 9, 2024 17:37
@probot-autolabeler probot-autolabeler bot added dependencies Pull requests that update a dependency file frontend javascript labels Apr 9, 2024
Copy link

what-the-diff bot commented Apr 9, 2024

PR Summary

  • Introduction of "signature_pad" Dependency
    A new dependency called "signature_pad" was introduced into the system. This enhancement is represented in the files package-lock.json and package.json, which keep track of the project's dependencies.

  • Improvements to create.blade.php File
    The "create.blade.php" file underwent several changes. The plotting area, generally known as 'canvas', was adjusted to occupy 100% of the available width for a better user interface.

    To enhance the responsiveness of the application, we've added a decision-making routine that resizes the canvas only when the window's width is 768px or higher.

    Additionally, we have removed an event listener that was previously linked to a function named 'resizeCanvas'. This function is not required anymore due to other improvements made to how the application handles changes in size.

@Godmartinz Godmartinz changed the title Signature pad upgrade Upgraded Signature-pad.js && Fixed Resizing Canvas on mobile Apr 9, 2024
@snipe snipe merged commit b5c8372 into snipe:develop Apr 11, 2024
8 checks passed
@marcusmoore marcusmoore mentioned this pull request Nov 21, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file frontend javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants