Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo optimize command in test after it is completed #15111

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

marcusmoore
Copy link
Collaborator

Description

This PR follows up on the test introduced in #15082 by cleaning up the cached config and routes that are generated when running the artisan optimize command after the test is run since it can cause some unexpected behavior on local environments.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@marcusmoore marcusmoore requested a review from snipe as a code owner July 17, 2024 19:25
Copy link

what-the-diff bot commented Jul 17, 2024

PR Summary

  • Enhanced Test File
    The file OptimizeTest.php in the tests/Feature/Console section has been updated. The changes will improve the way we test our console functionalities.

  • Added New Event
    A new event named beforeApplicationDestroyed was introduced. This event triggers two commands — config:clear and route:clear, right before shutting down the application. This action ensures that our system is clean and ready for a new start next time.

  • Updated Test Method
    The method testOptimizeSucceeds has now been updated to include the new event. This demonstrates that despite the inclusion of new events, our optimization command is still effectively working as expected.

@snipe snipe merged commit 1eb16cd into snipe:develop Jul 17, 2024
9 checks passed
@marcusmoore marcusmoore deleted the fixes/optimize-test branch July 17, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants