-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #10224: fix route names for optimize command #15082
Conversation
💖 Thanks for this pull request! 💖 We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
PR Summary
|
Thanks! This PR seems fine - we don't use the |
Thanks! I changed the target branch to develop. Sorry I missed that. |
Thanks! Looks like you might need to rebase. There's a bunch of stuff in there outside of this PR's changes files/commits. |
63a33c1
to
a175b6a
Compare
Yeah, you're right. I hope it's fixed now. |
Congrats on merging your first pull request! 🎉🎉🎉 |
Description
Fixes some duplicate route names in
routes/api.php
for theApi\AssetFilesController
:api.assets.files
was used for bothlist
andstore
api.assets.file
was used for bothshow
anddestroy
This led to
artisan route:cache
andartisan optimize
to fail (also see #11595 which fixed this for web routes).This PR also introduces a new
OptimizeTest
to ensure thatartisan optimize
runs successfully.Fixes #10224
Type of change
How Has This Been Tested?
Tests\Feature\Console\OptimizeTest