-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-organized test suite #14825
Re-organized test suite #14825
Conversation
PR Summary
Please note that these changes enhance the readability and organization of the testing files, making it more user-friendly for developers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it! Seems much more logical and manageable.
Description
This PR re-organizes the feature test suite by co-locating API and UI tests into "domains" resulting in the following directory structure:
I put "domains" in quotes because the top level folders under
Feature
are a mix of model specific "CRUDy" tests likeAssets/
, "domain-y" stuff likeCheckins/
andNotifications/
, and general tests likeDashboardTest
.One benefit of the
Api
andUi
folders under each parent folder allows us to easily see gaps in our test coverage instead of having to jump between stuff underFeatures/
and stuff underFeatures/Api/
.I have to confess that I like this structure now but that feeling may change in the future. Of course I am open to other suggestions.
I double-checked to make sure the same amount tests and assertions were made...
develop
branch:This PR:
Note: The single test case in
tests/Feature/Api/Users/UsersUpdateTest.php
was moved totests/Feature/Users/Api/UpdateUserTest.php
and the file was deleted.Type of change