Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-organized test suite #14825

Merged
merged 7 commits into from
Jun 5, 2024
Merged

Conversation

marcusmoore
Copy link
Collaborator

Description

This PR re-organizes the feature test suite by co-locating API and UI tests into "domains" resulting in the following directory structure:

Feature test suite

I put "domains" in quotes because the top level folders under Feature are a mix of model specific "CRUDy" tests like Assets/, "domain-y" stuff like Checkins/ and Notifications/, and general tests like DashboardTest.

One benefit of the Api and Ui folders under each parent folder allows us to easily see gaps in our test coverage instead of having to jump between stuff under Features/ and stuff under Features/Api/.

I have to confess that I like this structure now but that feeling may change in the future. Of course I am open to other suggestions.


I double-checked to make sure the same amount tests and assertions were made...
develop branch:

Tests: 312, Assertions: 1098, Skipped: 9.

This PR:

Tests: 312, Assertions: 1098, Skipped: 9.

Note: The single test case in tests/Feature/Api/Users/UsersUpdateTest.php was moved to tests/Feature/Users/Api/UpdateUserTest.php and the file was deleted.


Type of change

  • Chore

Copy link

what-the-diff bot commented Jun 4, 2024

PR Summary

  • File deletion
    One testing file (tests/Feature/Api/Users/UsersUpdateTest.php) was removed from the project.

  • File renaming
    A total of 28 testing files were renamed. This includes tests for several components in the system such as assets, accessories, check-ins, checkout acceptances, consumables, departments, groups, licenses, locations, reporting, and users. The renaming was carried out to ensure the names are better reflections of their functions in the system and they have consistent formatting.

  • Update of namespaces
    Namespaces of several testing files were updated. These modifications were done to align with the reorganized file structure and provide a clearer map of where each test file resides in the project.

Please note that these changes enhance the readability and organization of the testing files, making it more user-friendly for developers.

Copy link
Collaborator

@spencerrlongg spencerrlongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! Seems much more logical and manageable.

@snipe snipe merged commit 697ac83 into snipe:develop Jun 5, 2024
8 checks passed
@marcusmoore marcusmoore deleted the chore/test-organization branch June 5, 2024 17:58
@marcusmoore marcusmoore mentioned this pull request Jun 13, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants