Allow CompanyableTrait trait on users

[snipe]

This should allow us to automatically scope users to company instead of having to manually do it. Previously, adding the use CompanyableTrait; statement would get caught in an infinite loop, since Auth::check() internally calls Auth::user(), which makes the scope get caught on which user you want to be looking at for scoping.

Using Auth::hasUser() just returns the boolean value, which prevents this looping problem.

To test

• enable full multiple company support
• create a few users in a few different companies. give them permission to see assets, users, etc, but not superadmin
• create some assets in those same companies
• login as each of those users, and see that the results are scoped to the company the respective users belong to

[what-the-diff]

PR Summary

• Reworking of User Controller
  Removed dependencies on Company model in various functions of UsersController. It seems to streamline the code and make it less reliant on the Company model for certain operations.

• Refactoring of Company Model
  Changed the authentication checks in Company model for better security. Now it checks if there is an authenticated user rather than just performing a generic authentication check. The code also uses the authenticated user object directly, instead of referencing the user's company id. This seems to optimize the user authentication process in the application.

• Addition of CompanyableTrait to User Model
  Adding CompanyableTrait to the User model suggests increased modularity. This makes the User model more efficient and reduces redundancy by using traits to share common functionality across models. It ensures cleaner and more manageable code.

[snipe]

One thing I'm seeing here in the tests that I'm unsure about is that I'm getting:

   WARN  Tests\Feature\Users\ViewUserTest
  ✓ user without permissions cannot view user detail page
  ! user without permissions cannot view print all inventory page → Test code or tested code did not (only) close its own output buffers
  ✓ user without permissions cannot send inventory
  ✓ user without permissions cannot delete user

But I can't tell what's causing that warning.

[marcusmoore]

@snipe I tracked it down. That Test code or tested code did not (only) close its own output buffers is caused by a missing @endpush to close the @push('js') in users/print.blade.php.

[marcusmoore]

(I only looked into the test issues so far. Going to give it a full review soon.)

[snipe]

Omg, first, thank you, second fml

[snipe]

I tracked it down. That Test code or tested code did not (only) close its own output buffers is caused by a missing @endpush to close the push('js') in users/print.blade.php.

I don't even see a @push('js') in that file?

[snipe]

Nevermind, I'm an idiot lol

[marcusmoore]

Since this touches the API controller can we add tests for that as well? I think it would have caught the missing ->find() I mentioned below.

It'll be good to catch up to develop so the test is in the correct directory too 😄 (#14825)