Handle unconfirmed email #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stéphane Robino <[email protected]> Signed-off-by: Kévin Lacointe <[email protected]>
|
Thanks for the contribution!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
We are using coherence and we need to confirm user email on each update.
We found an issue and saw that the feature is missing but PR are welcome: #74
Here is a PR that add an option to require email update confirmation instead of directly updating the database. We are using the
unconfirmed_emailattributes that was already present on the migration file (but not used in the library)Can you please make a review on this?
Signed-off-by: Stéphane Robino [email protected]
Signed-off-by: Kévin Lacointe [email protected]