Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling unconfirmed emails #74

Open
vinnicc opened this issue Oct 15, 2016 · 3 comments
Open

Handling unconfirmed emails #74

vinnicc opened this issue Oct 15, 2016 · 3 comments

Comments

@vinnicc
Copy link
Contributor

vinnicc commented Oct 15, 2016

What would be the recommended way to handle subsequent unconfirmed emails? Coherence.Schema has this line commented out so I wonder if there's a plan to add this feature soon (like how Devise does it, without support for multiple emails though).

@smpallen99
Copy link
Owner

@vinnicc I believe the commented line came from the original schema I took from Devise. I have not looked into how that field is used.

If you would like to outline the use case here, I'll review and get back to you on recommendations.

Steve

@vinnicc
Copy link
Contributor Author

vinnicc commented Oct 15, 2016

Pretty much the same as Devise - when the user's first email has been confirmed and then updated to a different one, the new email could be temporarily stored in unconfirmed_email until confirmation:

https://github.com/plataformatec/devise/blob/master/lib/devise/models/confirmable.rb

This will be useful for the front end and to prevent the app from unintentionally blocking the user in some cases. I just thought this completes the "confirmable" behavior and you might want it included in the library.

@klacointe
Copy link
Contributor

@vinnicc @smpallen99 maybe we can close this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants