Improve configurability of connectors #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcoh
force-pushed
the
aws-config-connector-config
branch
from
41a6a47 to
c9c67c8
Compare
|
A new doc preview is ready to view. |
|
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
|
A new doc preview is ready to view. |
Velfi
reviewed
Dec 16, 2021
Velfi
reviewed
Dec 16, 2021
Velfi
reviewed
Dec 16, 2021
Velfi
reviewed
Dec 16, 2021
rcoh
force-pushed
the
aws-config-connector-config
branch
from
529a1a2 to
465c3fa
Compare
|
A new generated diff is ready to view.
|
|
A new doc preview is ready to view. |
Velfi
approved these changes
Dec 16, 2021
|
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
|
|
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
|
|
A new doc preview is ready to view. |
|
A new generated diff is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
Currently it's possible to use a fully custom connector with generated clients, but it's more cumbersome when using
aws-config. Furthermore, the type ofTcpConnectorwasn't ideal since it didn't actually work when HTTPS was needed.This change:
tcp_connectorto accept anything that Hyper can useprovider_configmethod (perhaps this should be namedconfigurefor symmetry?) toConfigLoaderTesting
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.