Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request]: Support custom connectors for aws-config and generated services #338

Closed
rcoh opened this issue Dec 13, 2021 · 2 comments
Closed
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue

Comments

@rcoh
Copy link
Contributor

rcoh commented Dec 13, 2021

Tell us about your request

support easily dropping in custom HTTPS and connector implementations

Tell us about the problem you're trying to solve.

  1. I want to be able to easily provide my own TLS implementation (eg. rustls with custom CA certs)
  2. It should be straightforward to set this both for aws-config as well as services like aws-s3

Are you currently working around this issue?

  • I can set a DynConnector for aws-config but it doesn't obey timeouts
  • with_tcp_connector expects something that returns TcpStream as a response but that doesn't actually work with connectors from rustls which return MaybeHttps as the response.

Additional context

No response

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue, please leave a comment
@rcoh rcoh added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 13, 2021
@Velfi Velfi removed the needs-triage This issue or PR still needs to be triaged. label Jan 18, 2022
@jmklix jmklix added the p2 This is a standard priority issue label Nov 28, 2022
@Velfi
Copy link
Contributor

Velfi commented Aug 3, 2023

@Velfi Velfi closed this as completed Aug 3, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

3 participants