New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SDK external types #3080

Merged

rcoh merged 5 commits into main from update-external-types

Oct 30, 2023

Collaborator

rcoh commented Oct 18, 2023

Motivation and Context

Design/Implement runtime crates versioning strategy #3019

Description

Prune / split out allow external types

Testing

CI

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

rcoh requested a review from a team as a code owner

October 18, 2023 17:17

jdisanti reviewed

View reviewed changes

aws/sdk/sdk-external-types.toml

-                  "http::uri::Uri",
-                  "http::method::Method",
+                  ### All below this line need to be fixed:

Collaborator

jdisanti Oct 18, 2023

The event stream one at the very bottom doesn't need to be fixed. It just needs a tooling upgrade.

Collaborator Author

rcoh Oct 18, 2023

the crate won't go 1.0 though—we might want a newtype?

aws/sdk/sdk-external-types.toml Outdated

-                  "http::header::map::HeaderMap",
-                  "http::header::value::HeaderValue",
+                  "aws_smithy_runtime_api::*",
+                  "aws_smithy_runtime::*",

Collaborator

jdisanti Oct 18, 2023

Since this will be an unstable crate, we should be careful about what gets allowed here.

Collaborator Author

rcoh Oct 18, 2023

oh good catch, bad copy-paste by me. It's actually unused.

rcoh enabled auto-merge

October 18, 2023 17:35

github-actions bot commented Oct 18, 2023

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

rcoh requested a review from a team as a code owner

October 19, 2023 12:57

rcoh force-pushed the update-external-types branch from 7db3ee9 to 3483d09 Compare

October 19, 2023 12:58

github-actions bot commented Oct 19, 2023

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

Velfi approved these changes

View reviewed changes

github-actions bot commented Oct 23, 2023

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

rcoh force-pushed the update-external-types branch from c9075ee to f815cd0 Compare

October 23, 2023 15:11

github-actions bot commented Oct 23, 2023

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

rcoh force-pushed the update-external-types branch from f815cd0 to 6ef4028 Compare

October 25, 2023 19:05

github-actions bot commented Oct 25, 2023

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

rcoh force-pushed the update-external-types branch from 6ef4028 to dfc5097 Compare

October 25, 2023 20:09

github-actions bot commented Oct 25, 2023

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

rcoh added 5 commits

October 30, 2023 09:31


          Update SDK external types

05fb0ca


          Cleanups, remove stale items

6b978c5


          Remove endpoint now that PR is merged

3a90a15


          Bring back event stream type

10e3dcf


          Add IdentityCache

c9b880e

rcoh force-pushed the update-external-types branch from dfc5097 to c9b880e Compare

October 30, 2023 13:31

github-actions bot commented Oct 30, 2023

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

rcoh added this pull request to the merge queue

Merged via the queue into main with commit 06e265d

rcoh deleted the update-external-types branch

October 30, 2023 14:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet