Skip to content

Commit

Permalink
Update SDK external types (#3080)
Browse files Browse the repository at this point in the history
## Motivation and Context
- #3019

## Description
Prune / split out allow external types

## Testing
- CI

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
  • Loading branch information
rcoh authored Oct 30, 2023
1 parent 5a8b07c commit 06e265d
Showing 1 changed file with 22 additions and 13 deletions.
35 changes: 22 additions & 13 deletions aws/sdk/sdk-external-types.toml
Original file line number Diff line number Diff line change
@@ -1,22 +1,31 @@
# These are the allowed external types in the `aws-sdk-*` generated crates, checked by CI.
allowed_external_types = [
"aws_credential_types::*",
"aws_http::*",
"aws_runtime::*",
"aws_smithy_async::*",
"aws_smithy_http::*",
"aws_smithy_runtime::*",
"aws_smithy_runtime_api::*",
"aws_smithy_types::*",
"aws_credential_types::*",
"aws_types::*",

"http::header::map::HeaderMap",
"http::header::value::HeaderValue",
"aws_smithy_runtime_api::*",
"aws_smithy_async::rt::sleep::*",
"aws_smithy_async::time::*",
"aws_smithy_async::future::pagination_stream::PaginationStream",
# only allowed in from impl for presigned request
"http::request::Request",
"http::error::Error",
"http::uri::Uri",
"http::method::Method",

# TODO(https://github.com/awslabs/smithy-rs/issues/1193): Once tooling permits it, only allow the following types in the `event-stream` feature
"aws_smithy_eventstream::*",

# Consider moving making this crate 1.0
"aws_smithy_runtime::client::identity::cache::IdentityCache",

### All below this line need to be fixed:
# The following are not OK
"aws_http::request_id::RequestId", # move to aws-types
# `set_invocation_id_generator` — consider make pub(crate) or moving trait to AwsTypes
"aws_runtime::invocation_id::SharedInvocationIdGenerator",
"aws_runtime::invocation_id::InvocationIdGenerator",

# Pending fix in open PRs:
"aws_smithy_http::result::*",

# Pending future fix
"aws_smithy_http::event_stream::*",
]

0 comments on commit 06e265d

Please sign in to comment.