Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a module for the last release date in canary #3013

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Update a module for the last release date in canary #3013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tools/ci-cdk/canary-lambda/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@ mod latest;
#[cfg(feature = "latest")]
pub(crate) use latest as current_canary;

// NOTE: This module can be deleted 3 releases after release-2023-08-23
#[cfg(feature = "release-2023-08-23")]
mod release_2023_08_23;
#[cfg(feature = "release-2023-08-23")]
pub(crate) use release_2023_08_23 as current_canary;
// NOTE: This module can be deleted 3 releases after release-2023-09-25
#[cfg(feature = "release-2023-09-25")]
mod release_2023_09_25;
#[cfg(feature = "release-2023-09-25")]
pub(crate) use release_2023_09_25 as current_canary;

#[tokio::main]
async fn main() -> Result<(), Error> {
Expand Down
0 ...k/canary-lambda/src/release_2023_08_23.rs → ...k/canary-lambda/src/release_2023_09_25.rs
View file
Open in desktop
File renamed without changes.
0 ...rc/release_2023_08_23/paginator_canary.rs → ...rc/release_2023_09_25/paginator_canary.rs
View file
Open in desktop
File renamed without changes.
0 ...ambda/src/release_2023_08_23/s3_canary.rs → ...ambda/src/release_2023_09_25/s3_canary.rs
View file
Open in desktop
File renamed without changes.
0 ...c/release_2023_08_23/transcribe_canary.rs → ...c/release_2023_09_25/transcribe_canary.rs
View file
Open in desktop
File renamed without changes.
14 changes: 7 additions & 7 deletions tools/ci-cdk/canary-runner/src/build_bundle.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ const REQUIRED_SDK_CRATES: &[&str] = &[
// The elements in this `Vec` should be sorted in an ascending order by the release date.
lazy_static! {
static ref NOTABLE_SDK_RELEASE_TAGS: Vec<ReleaseTag> = vec![
ReleaseTag::from_str("release-2023-08-23").unwrap(), // last version before `Stream` trait removal
ReleaseTag::from_str("release-2023-09-25").unwrap(), // last version before `Stream` trait removal
];
}

Expand Down Expand Up @@ -442,7 +442,7 @@ aws-sdk-transcribestreaming = { path = "some/sdk/path/transcribestreaming" }

[features]
latest = []
"release-2023-08-23" = []
"release-2023-09-25" = []
default = ["latest"]
"#,
generate_crate_manifest(CrateSource::Path("some/sdk/path".into())).expect("success")
Expand Down Expand Up @@ -506,7 +506,7 @@ aws-sdk-transcribestreaming = "0.16.0"

[features]
latest = []
"release-2023-08-23" = []
"release-2023-09-25" = []
default = ["latest"]
"#,
generate_crate_manifest(CrateSource::VersionsManifest {
Expand All @@ -524,7 +524,7 @@ default = ["latest"]
.collect(),
release: None,
},
release_tag: ReleaseTag::from_str("release-2023-08-26").unwrap(),
release_tag: ReleaseTag::from_str("release-9999-12-31").unwrap(),
})
.expect("success")
);
Expand Down Expand Up @@ -585,14 +585,14 @@ default = ["latest"]
}),
);
assert_eq!(
"release-2023-08-23".to_string(),
"release-2023-09-25".to_string(),
enabled_feature(&CrateSource::VersionsManifest {
versions: versions.clone(),
release_tag: "release-2023-08-23".parse().unwrap(),
release_tag: "release-2023-09-25".parse().unwrap(),
}),
);
assert_eq!(
"release-2023-08-23".to_string(),
"release-2023-09-25".to_string(),
enabled_feature(&CrateSource::VersionsManifest {
versions,
release_tag: "release-2023-01-13".parse().unwrap(),
Expand Down