Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a module for the last release date in canary #3013

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

ysaito1001
Copy link
Contributor

Motivation and Context

Fixes canary failures by updating the-last-release-before-breaking-change module in canary-lambda.

Description

A previous PR removing the Steram trait from public API had a breaking change, requiring canary to update its code. The latest release at the time while the PR was worked on was release-2023-08-23 so we created a new module with that date and moved the previously working canary's code prior to the breaking change to it. The latest module then contained canary's code after the breaking change.

However, before that PR was merged to main, we made several releases in aws-sdk-rust, making release-2023-08-23 no longer the latest release before the breaking change; a new one is release_2023_09_25. Hence this PR.

Testing

Manually executed

➜ canary-runner git:(ysaito/fix-canary-module-dates) cargo run -- build-bundle --canary-path ../canary-lambda --sdk-release-tag release-2023-09-25 --musl --manifest-only
➜ canary-runner git:(ysaito/fix-canary-module-dates) cd ../canary-lambda
➜ canary-lambda git:(ysaito/fix-canary-module-dates) cargo check

(also tested for --sdk-release-tag with release-2023-09-22 and release-2023-09-20)


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ysaito1001 ysaito1001 requested review from a team as code owners September 29, 2023 17:31
@github-actions
Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@ysaito1001 ysaito1001 added this pull request to the merge queue Sep 29, 2023
Merged via the queue into main with commit 398ad9e Sep 29, 2023
40 of 41 checks passed
@ysaito1001 ysaito1001 deleted the ysaito/fix-canary-module-dates branch September 29, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants