Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove middleware - part 2 #2925

Merged
merged 15 commits into from
Aug 21, 2023
Merged

Remove middleware - part 2 #2925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
93e4cf7
Remove middleware operation customizations
jdisanti Aug 15, 2023
6ea3bae
Remove fluent client generics switching logic
jdisanti Aug 15, 2023
0e8527d
Address TODO for customizable operations
jdisanti Aug 15, 2023
550fffd
Remove old client methods
jdisanti Aug 15, 2023
ef3814c
Fix fluent client docs
jdisanti Aug 15, 2023
6f11e17
Remove `propertyBagAvailable`
jdisanti Aug 15, 2023
47e7cc1
Remove runtime mode check from customizable operation
jdisanti Aug 15, 2023
ada506b
Remove SDK tower inlineables
jdisanti Aug 15, 2023
e52c2c6
Remove `algorithmWasCloned`
jdisanti Aug 15, 2023
1ee797d
Fix SigV4 signing
jdisanti Aug 16, 2023
b20eb1c
Fix dead code lint
jdisanti Aug 16, 2023
81eff0c
Fix Code Catalyst codegen
jdisanti Aug 16, 2023
ad489af
Fix function name
jdisanti Aug 16, 2023
42f2904
Merge remote-tracking branch 'origin/main' into jdisanti-remove-middl…
jdisanti Aug 21, 2023
772fcfb
Incorporate feedback
jdisanti Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions aws/rust-runtime/aws-inlineable/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ aws-smithy-http-tower = { path = "../../../rust-runtime/aws-smithy-http-tower" }
aws-smithy-runtime-api = { path = "../../../rust-runtime/aws-smithy-runtime-api", features = ["client"] }
aws-smithy-runtime = { path = "../../../rust-runtime/aws-smithy-runtime", features = ["client"] }
aws-smithy-types = { path = "../../../rust-runtime/aws-smithy-types" }
aws-smithy-async = { path = "../../../rust-runtime/aws-smithy-async" }
aws-smithy-async = { path = "../../../rust-runtime/aws-smithy-async", features = ["rt-tokio"] }
aws-types = { path = "../aws-types" }
bytes = "1"
bytes-utils = "0.1.1"
Expand All @@ -36,7 +36,6 @@ md-5 = "0.10.1"
ring = "0.16"
tokio = { version = "1.23.1", features = ["full"] }
tokio-stream = "0.1.5"
tower = { version = "0.4", default-features = false }
tracing = "0.1"

[dev-dependencies]
Expand Down
6 changes: 0 additions & 6 deletions aws/rust-runtime/aws-inlineable/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@ pub mod no_credentials;
/// Support types required for adding presigning to an operation in a generated service.
pub mod presigning;

/// Presigning tower service
pub mod presigning_service;

/// Presigning interceptors
pub mod presigning_interceptors;

Expand All @@ -43,9 +40,6 @@ pub mod glacier_checksums;
/// Glacier-specific behavior
pub mod glacier_interceptors;

/// Default middleware stack for AWS services
pub mod middleware;

/// Strip prefixes from IDs returned by Route53 operations when those IDs are used to construct requests
pub mod route53_resource_id_preprocessor_middleware;

Expand Down
88 changes: 0 additions & 88 deletions aws/rust-runtime/aws-inlineable/src/middleware.rs
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions aws/rust-runtime/aws-inlineable/src/presigning.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ impl PresigningConfigBuilder {
pub struct PresignedRequest(http::Request<()>);

impl PresignedRequest {
#[allow(dead_code)]
pub(crate) fn new(inner: http::Request<()>) -> Self {
Self(inner)
}
Expand Down
61 changes: 0 additions & 61 deletions aws/rust-runtime/aws-inlineable/src/presigning_service.rs
View file
Open in desktop

This file was deleted.

182 changes: 0 additions & 182 deletions aws/rust-runtime/aws-inlineable/tests/middleware_e2e_test.rs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion aws/sdk-codegen/src/main/kotlin/software/amazon/smithy/rustsdk/AwsCodegenDecorator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ val DECORATORS: List<ClientCodegenDecorator> = listOf(
RequireEndpointRules(),
UserAgentDecorator(),
SigV4AuthDecorator(),
SigV4SigningDecorator(),
HttpRequestChecksumDecorator(),
HttpResponseChecksumDecorator(),
RetryClassifierDecorator(),
Expand Down
Loading