Remove middleware - part 2 #2925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdisanti
force-pushed
the
jdisanti-remove-middleware-pt2
branch
from
6f04e17 to
a2ea7fe
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
force-pushed
the
jdisanti-remove-middleware-pt2
branch
from
12c2ffe to
ad489af
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
reviewed
Aug 21, 2023
...amazon/smithy/rust/codegen/client/smithy/generators/client/CustomizableOperationGenerator.kt
Outdated
Show resolved
Hide resolved
Velfi
reviewed
Aug 21, 2023
...amazon/smithy/rust/codegen/client/smithy/generators/client/CustomizableOperationGenerator.kt
Outdated
Show resolved
Hide resolved
Velfi
reviewed
Aug 21, 2023
...tlin/software/amazon/smithy/rust/codegen/client/smithy/generators/client/FluentClientDocs.kt
Show resolved
Hide resolved
Velfi
reviewed
Aug 21, 2023
...tlin/software/amazon/smithy/rust/codegen/client/smithy/generators/client/FluentClientDocs.kt
Show resolved
Hide resolved
Velfi
reviewed
Aug 21, 2023
...tlin/software/amazon/smithy/rust/codegen/client/smithy/generators/client/FluentClientDocs.kt
Outdated
Show resolved
Hide resolved
Velfi
reviewed
Aug 21, 2023
...tlin/software/amazon/smithy/rust/codegen/client/smithy/generators/client/FluentClientDocs.kt
Outdated
Show resolved
Hide resolved
Velfi
reviewed
Aug 21, 2023
Comment on lines
-88
to
+85
| val customizableOperationGenerator = CustomizableOperationGenerator(codegenContext, generics, customizableOperationCustomizations) | ||
| val customizableOperationGenerator = CustomizableOperationGenerator(codegenContext, customizableOperationCustomizations) |
There was a problem hiding this comment.
How good it feels to see that argument go the way of the dinosaurs.
Velfi
approved these changes
Aug 21, 2023
|
I'm so excited to get this PR merged! Thanks for putting all this together John. |
jdisanti
force-pushed
the
jdisanti-remove-middleware-pt2
branch
from
2fe61dc to
772fcfb
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues removing middleware by addressing the simpler
TODO(enableNewSmithyRuntimeCleanup)comments in the code generator.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.