Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set RUSTUP_TOOLCHAIN in Dockerfile #2853

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Set RUSTUP_TOOLCHAIN in Dockerfile #2853

merged 1 commit into from
Jul 18, 2023

Conversation

rcoh
Copy link
Collaborator

@rcoh rcoh commented Jul 18, 2023

Motivation and Context

During releases, if the toolchain version has changed, we'll try to invoke a Rust version that doesn't exist. This pins it to the stable version.

Description

Set the RUSTUP_TOOLCHAIN environment variable in the release/CI dockerfile

Testing

  • ran a release with this image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rcoh rcoh requested review from a team as code owners July 18, 2023 17:03
@rcoh rcoh force-pushed the rustup-toolchain-dockerfile branch from e2e6da9 to 3d63daa Compare July 18, 2023 17:03
@rcoh rcoh enabled auto-merge July 18, 2023 17:03
@rcoh rcoh added this pull request to the merge queue Jul 18, 2023
@github-actions
Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

Merged via the queue into main with commit fabef2b Jul 18, 2023
@rcoh rcoh deleted the rustup-toolchain-dockerfile branch July 18, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants