Skip to content

Commit

Permalink
Set RUSTUP_TOOLCHAIN in Dockerfile (#2853)
Browse files Browse the repository at this point in the history
## Motivation and Context
During releases, if the toolchain version has changed, we'll try to
invoke a Rust version that doesn't exist. This pins it to the stable
version.

## Description
Set the `RUSTUP_TOOLCHAIN` environment variable in the release/CI
dockerfile

## Testing
- ran a release with this image


----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
  • Loading branch information
rcoh authored Jul 18, 2023
1 parent d4c5064 commit fabef2b
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions tools/ci-build/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -207,4 +207,7 @@ ENV SMITHY_RS_DOCKER_BUILD_IMAGE=1
RUN pip3 install --no-cache-dir mypy==0.991
WORKDIR /home/build
COPY sanity-test /home/build/sanity-test
# RUSTUP_TOOLCHAIN takes precedence over everything except `+<toolchain>` args. This will allow us to ignore the toolchain
# file during CI, avoiding issues during Rust version upgrades.
ENV RUSTUP_TOOLCHAIN=${rust_stable_version}
RUN /home/build/sanity-test

0 comments on commit fabef2b

Please sign in to comment.