-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC30 #2615
base: main
Are you sure you want to change the base?
RFC30 #2615
Conversation
82df0f7
to
f6548ec
Compare
6b54255
to
fd74029
Compare
NOTE: this one's fixed. Only error that I'm facing is this, which comes from
UPDATE: fixed tokio-rs/tracing#2565 |
5096e7f
to
31780e7
Compare
So I reorganized the PR/code. I really wanted to make use of I really hopes this approach works. Thank you very much for you and your team's continuous support! |
…ng Cargo from kotlin (#2614) ## Motivation and Context This PR set `aws_sdk_unstable` to RUSTFALGS when running cargo from kotlin. It is required to enable test gated features introduced on RFC30. No breaking changers are introduced. ## Description add `RUSTFLAGS = aws_sdk_unstable` when running cargo from kotlin. ## Parent PR This PR is listed as one of prerequisite PRs on this PR. - #2615 ## Testing NA. ---- *By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.*
…-k-cameron/smithy-rs into RFC30/kotlin-codegen-core
Never seen this error before.
|
…codegen/client/smithy/customize/SerdeDecorator.kt modified: codegen-client/src/main/kotlin/software/amazon/smithy/rust/codegen/client/smithy/generators/ServiceGenerator.kt modified: codegen-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/smithy/generators/BuilderGenerator.kt modified: codegen-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/testutil/Rust.kt deleted: rust-runtime/aws-smithy-compiler-warning/Cargo.toml deleted: rust-runtime/aws-smithy-compiler-warning/src/lib.rs
…degen/core/testutil/Rust.kt
## Motivation and Context This is a sub-PR of #2615. Refactors `blob.rs` file. ## Description Some test was failing due to unnecessary import; This PR fixes it. ## Testing NA ## Checklist NA ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Co-authored-by: Zelda Hessler <[email protected]>
…codegen/client/smithy/customize/SerdeDecorator.kt modified: codegen-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/smithy/generators/LibRsGenerator.kt modified: codegen-core/src/test/kotlin/software/amazon/smithy/rust/codegen/core/smithy/generators/BuilderGeneratorTest.kt
Motivation and Context
This PR implements features described on RFC30 except for compile time benchmark.
Benchmark is submitted as a separate PR #2617.
Once this PR and #2617 is merged, RFC30 is complete.
Initially, we tried to make commit to
unstable-serde-support
branch and merge changes one by one in small PRs. However, in order to make it up to date with the main branch, we would need to go through a large PR of over 700 files.By merging it directly to the main branch, we can reduce this to under 30 files.
Prerequisite PRs
This is a list of prerequisite PRs; You can reduce the diff if you merge them earlier.
None of them introduces breaking changes.
RUSTFLAGS = aws_sdk_unstable
as environment variable when running Cargo from kotlin #2614EDIT:
More sub-PR.
serde
attributes are not added to error types #2803aws_sdk_unstable
to RUSTFLAG on one of the kotlin test #2804EDIT2:
More sub-PR.
Description
List of changes:
rust runtime
Number
,Blob
,Document
,DateTime
buildSrc
Core codegen code
serde
attributesserde
crate to enableserde(skip)
on some namespacesserde
crate behind unstable feature gate onCargo.toml
Client codegen code
serde
as dependency behind feature gateTesting
Checklist
CHANGELOG.next.toml
if I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.toml
if I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.