Add RUSTFLAGS = aws_sdk_unstable as environment variable when running Cargo from kotlin
#2614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-k-cameron
changed the title
RUSTFLAGS = aws_sdk_unstable as environment variable when running Cargo from kotlin
This was referenced Apr 26, 2023
Open
Velfi
approved these changes
Apr 26, 2023
david-perez
pushed a commit
that referenced
this pull request
May 18, 2023
…ng Cargo from kotlin (#2614) ## Motivation and Context This PR set `aws_sdk_unstable` to RUSTFALGS when running cargo from kotlin. It is required to enable test gated features introduced on RFC30. No breaking changers are introduced. ## Description add `RUSTFLAGS = aws_sdk_unstable` when running cargo from kotlin. ## Parent PR This PR is listed as one of prerequisite PRs on this PR. - #2615 ## Testing NA. ---- *By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.*
david-perez
pushed a commit
that referenced
this pull request
May 22, 2023
…ng Cargo from kotlin (#2614) ## Motivation and Context This PR set `aws_sdk_unstable` to RUSTFALGS when running cargo from kotlin. It is required to enable test gated features introduced on RFC30. No breaking changers are introduced. ## Description add `RUSTFLAGS = aws_sdk_unstable` when running cargo from kotlin. ## Parent PR This PR is listed as one of prerequisite PRs on this PR. - #2615 ## Testing NA. ---- *By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.*
david-perez
pushed a commit
that referenced
this pull request
May 22, 2023
…ng Cargo from kotlin (#2614) ## Motivation and Context This PR set `aws_sdk_unstable` to RUSTFALGS when running cargo from kotlin. It is required to enable test gated features introduced on RFC30. No breaking changers are introduced. ## Description add `RUSTFLAGS = aws_sdk_unstable` when running cargo from kotlin. ## Parent PR This PR is listed as one of prerequisite PRs on this PR. - #2615 ## Testing NA. ---- *By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.*
david-perez
added a commit
that referenced
this pull request
Jun 3, 2024
…nds via Gradle tasks Otherwise, if you generate a crate and compile it using Gradle, like for example using the invocation: ``` ./gradlew -P modules='simple' -P cargoCommands='test' codegen-server-test:build ``` And then manually run a `cargo` command within the generated crate directory, or open the project using `rust-analyzer`, Cargo will re-compile the project from scratch, with `CARGO_LOG=cargo::core::compiler::fingerprint=trace` reporting that flags have changed since the last compilation. Instead, it's best if we persist these flags to `.cargo/config.toml`, so all `cargo` invocations, either through Gradle, manually, or through `rust-analyzer`, use the same set. This way, if no files were changed, subsequent compilations since code generation will truly be no-ops, with Cargo reusing all artifacts. Note this commit fixes a regression that was introduced when `--cfg aws_sdk_unstable` was introduced in #2614, since I fixed this the first time back in #1422.
david-perez
added a commit
that referenced
this pull request
Jun 3, 2024
…nds via Gradle tasks Otherwise, if you generate a crate and compile it using Gradle, like for example using the invocation: ``` ./gradlew -P modules='simple' -P cargoCommands='test' codegen-server-test:build ``` And then manually run a `cargo` command within the generated crate directory, or open the project using `rust-analyzer`, Cargo will re-compile the project from scratch, with `CARGO_LOG=cargo::core::compiler::fingerprint=trace` reporting that flags have changed since the last compilation. Instead, it's best if we persist these flags to `.cargo/config.toml`, so all `cargo` invocations, either through Gradle, manually, or through `rust-analyzer`, use the same set. This way, if no files were changed, subsequent compilations since code generation will truly be no-ops, with Cargo reusing all artifacts. Note this commit fixes a regression that was introduced when `--cfg aws_sdk_unstable` was introduced in #2614, since I fixed this the first time back in #1422.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
…nds via Gradle tasks (#3678) Otherwise, if you generate a crate and compile it using Gradle, like for example using the invocation: ``` ./gradlew -P modules='simple' -P cargoCommands='test' codegen-server-test:build ``` And then manually run a `cargo` command within the generated crate directory, or open the project using `rust-analyzer`, Cargo will re-compile the project from scratch, with `CARGO_LOG=cargo::core::compiler::fingerprint=trace` reporting that flags have changed since the last compilation. Instead, it's best if we persist these flags to `.cargo/config.toml`, so all `cargo` invocations, either through Gradle, manually, or through `rust-analyzer`, use the same set. This way, if no files were changed, subsequent compilations since code generation will truly be no-ops, with Cargo reusing all artifacts. Note this commit fixes a regression that was introduced when `--cfg aws_sdk_unstable` was introduced in #2614, since I fixed this the first time back in #1422. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR set
aws_sdk_unstableto RUSTFALGS when running cargo from kotlin.It is required to enable test gated features introduced on RFC30.
No breaking changers are introduced.
Description
add
RUSTFLAGS = aws_sdk_unstablewhen running cargo from kotlin.Parent PR
This PR is listed as one of prerequisite PRs on this PR.
Testing
NA.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.