Move ClientBuilderGenerator out of codegen-client
#2159
Conversation
...c/test/kotlin/software/amazon/smithy/rust/codegen/core/smithy/generators/InstantiatorTest.kt
Outdated
Show resolved
Hide resolved
| { | ||
| "k1": { "map": {} }, | ||
| "k2": { "map": { "k3": {} } }, | ||
| "k3": { } | ||
| } | ||
| """, |
There was a problem hiding this comment.
ktlint complained here and below.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
| interface BuilderGenerator { | ||
| fun render(writer: RustWriter) | ||
| fun renderConvenienceMethod(implBlock: RustWriter) | ||
| } |
There was a problem hiding this comment.
I'm not a fan of this since it makes the builders inherit from unit test code, but it seems like this might go away due to #2342? Perhaps we merge that PR first and then delete this BuilderGenerator interface.
| @@ -370,3 +376,23 @@ open class Instantiator( | |||
| else -> throw CodegenException("Unrecognized shape `$shape`") | |||
| } | |||
| } | |||
| fun StructureShape.builderSymbol(symbolProvider: RustSymbolProvider): Symbol { | |||
There was a problem hiding this comment.
We should add a symbolForBuilder(shape: Shape) to RustSymbolProvider instead of this approach (there are examples in there for operation error and event stream error symbols). The module location needs to be configurable for my crate reorganization work.
|
Hmmm... Digging into this more, I'm thinking we should actually keep a minimal |
|
This PR has been sitting around for a while. Is it still relevant or can we close it? |
Motivation and Context
Closes #1970.
Description
Move a whole bunch of client-specific code from
codegen-coretocodegen-client.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.