Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move BuilderGenerator.kt (the entire file), together with its tests, to codegen-client (and rename it to ClientBuilderGenerator). #1970

Open
Tracked by #1401
crisidev opened this issue Nov 9, 2022 · 1 comment
Open
Tracked by #1401

Move BuilderGenerator.kt (the entire file), together with its tests, to codegen-client (and rename it to ClientBuilderGenerator). #1970

crisidev opened this issue Nov 9, 2022 · 1 comment
Labels
client refactoring Changes that do not affect our users, mostly focused on maintainability
Milestone
Server GA

Comments

@crisidev
Copy link
Contributor

crisidev commented Nov 9, 2022

No description provided.

@crisidev crisidev mentioned this issue Nov 9, 2022
Open
23 tasks
@spinski spinski added this to the Server GA milestone Nov 24, 2022
@david-perez david-perez mentioned this issue Dec 15, 2022
Merged
@jjant jjant moved this from To do to In progress in Server SDK (Developer preview) Dec 21, 2022
@jjant jjant self-assigned this Dec 21, 2022
@LukeMathWalker LukeMathWalker added the refactoring Changes that do not affect our users, mostly focused on maintainability label Dec 21, 2022
@jjant jjant moved this from In progress to Done in Server SDK (Developer preview) Jan 3, 2023
@jjant jjant moved this from Done to In progress in Server SDK (Developer preview) Jan 3, 2023
@jjant jjant mentioned this issue Jan 3, 2023
Closed
@jjant jjant moved this from In progress to In Review in Server SDK (Developer preview) Jan 16, 2023
@david-perez david-perez mentioned this issue Sep 13, 2023
Merged
2 tasks
@rcoh
Copy link
Collaborator

rcoh commented Sep 15, 2023

In case anyone wants to try this, the tricky issue is the tests that rely on it like the tests for the parser generators that rely on it.

@jjant jjant removed their assignment Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client refactoring Changes that do not affect our users, mostly focused on maintainability
Projects
None yet
Milestone
Server GA
Development

Successfully merging a pull request may close this issue.

Move ClientBuilderGenerator out of codegen-client smithy-lang/smithy-rs
6 participants
@jdisanti @rcoh @crisidev @jjant @LukeMathWalker @spinski