Run cargo clippy when building the Pokémon Service
#1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-perez
reviewed
Sep 19, 2022
| @@ -7,4 +7,6 @@ set -eux | |||
| cd smithy-rs/rust-runtime/aws-smithy-http-server/examples | |||
|
|
|||
| make | |||
| cargo test | |||
| make clippy | |||
There was a problem hiding this comment.
It should suffice to just have:
make test clippy
in both Makefiles.
There was a problem hiding this comment.
So you want me to edit the Makefiles? Or you mean in the check-server-(python-)e2e-test files to just condense what I have into make test clippy (I am assuming the latter, just want to make sure).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This is meant to fix this open issue: #1727
Description
cargo clippyas part of it's build' -- this happens both for the Rust and Python examples.Testing
I wasn't exactly able to find what tests were relevant, other than just just running
ci-action check-server-e2e-testandci-action check-server-python-e2e-test-- Both of which reflected the addition of `cargo clippy'For good measure, I ran all other tests.
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.