Skip to content

Commit

Permalink
Run cargo clippy when building the Pokémon Service (#1742)
Browse files Browse the repository at this point in the history
  • Loading branch information
GeneralSwiss authored Sep 21, 2022
1 parent 81eb732 commit ff13b08
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 4 deletions.
8 changes: 7 additions & 1 deletion CHANGELOG.next.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,10 @@
# message = "Fix typos in module documentation for generated crates"
# references = ["smithy-rs#920"]
# meta = { "breaking" = false, "tada" = false, "bug" = false, "target" = "client | server | all"}
# author = "rcoh"
# author = "rcoh"

[[rust-runtime]]
message = "Pokémon Service example code now runs clippy during build."
references = ["smithy-rs#1727"]
meta = { "breaking" = false, "tada" = false, "bug" = false }
author = "GeneralSwiss"
3 changes: 3 additions & 0 deletions rust-runtime/aws-smithy-http-server-python/examples/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ codegen:
cp -av $(SERVER_SDK_SRC)/* $(SERVER_SDK_DST)/
cp -av $(CLIENT_SDK_SRC)/* $(CLIENT_SDK_DST)/

clippy: codegen
cargo clippy

build: codegen
cargo build
ln -sf $(DEBUG_SHARED_LIBRARY_SRC) $(SHARED_LIBRARY_DST)
Expand Down
6 changes: 6 additions & 0 deletions rust-runtime/aws-smithy-http-server/examples/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@ build: codegen
run: codegen
cargo run

clippy: codegen
cargo clippy

test: codegen
cargo test

doc-open: codegen
cargo doc --no-deps --open

Expand Down
3 changes: 1 addition & 2 deletions tools/ci-build/scripts/check-server-e2e-test
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,4 @@
set -eux
cd smithy-rs/rust-runtime/aws-smithy-http-server/examples

make
cargo test
make test clippy
2 changes: 1 addition & 1 deletion tools/ci-build/scripts/check-server-python-e2e-test
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@
set -eux
cd smithy-rs/rust-runtime/aws-smithy-http-server-python/examples

make test
make test clippy

0 comments on commit ff13b08

Please sign in to comment.