Fix smithy sdk no default client #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aajtodd
approved these changes
Jan 10, 2022
| @@ -72,7 +73,7 @@ class ServiceGenerator(private val ctx: RenderingContext<ServiceShape>) { | |||
| SectionServiceCompanionObject, | |||
| context = mapOf(SectionServiceCompanionObject.ServiceSymbol to serviceSymbol) | |||
| ) { | |||
| renderCompanionObject() | |||
| renderCompanionObject(ctx.protocolGenerator != null) | |||
There was a problem hiding this comment.
style
ctx is a property on the class, no real reason to thread through the parameter
| withBlock("operator fun invoke(block: Config.Builder.() -> Unit = {}): ${serviceSymbol.name} {", "}") { | ||
| write("val config = Config.Builder().apply(block).build()") | ||
| write("return Default${serviceSymbol.name}(config)") | ||
| this.callIf(hasProtocolGenerator) { |
There was a problem hiding this comment.
nit/style does this need qualified here?
ianbotsf
approved these changes
Jan 10, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
N/A
Description of changes
smithy-kotlin. As-is, any generated Smithy client SDK is invalid (does not compile) because the client interface codegens references to a concrete client type that is not generated because no protocol is available. This has impact in codegen tests where we have to write test code in a specific way in order for the smithy sdk to compile, and also impacts ongoing work to develop and test kmp projects. It is likely that we'll have some kind of protocol in the future insmithy-kotlinat which point we may wish to revert this change, however this is unlikely to happen soon and so I choose this approach so that codegen tests can be cleaned up and kmp work can be unblocked. Also we'll probably always want to retain the capability to generate a client sdk sans protocol.Additional Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.