Skip to content

fix(ci): disable Docker layer cache for engine image builds - #878

Merged
slin1237 merged 1 commit into
mainfrom
fix/engine-docker-no-cache
Mar 24, 2026
Merged

slin1237 merged 1 commit into
mainfrom
fix/engine-docker-no-cache

Conversation

@slin1237

@slin1237 slin1237 commented Mar 24, 2026 •

Copy link
Copy Markdown
Member

Description

Engine docker builds were serving stale pip install layers from Docker cache, causing images to contain old smg-grpc-proto/servicer versions even after new releases.

Changes

  • .github/workflows/_build-engine-image.yml: Add no-cache: true to the docker build step

Test Plan

  • After merge, trigger vLLM docker build and verify pip freeze shows latest packages
Checklist
  • Workflow updated
  • (Optional) Please join us on Slack #sig-smg to discuss, review, and merge PRs

Summary by CodeRabbit

Release Notes

No end-user-visible changes in this release. This update modifies internal build infrastructure only.

The pip install layer for smg-grpc-proto and smg-grpc-servicer was
being served from Docker's layer cache even after new versions were
published to PyPI, causing freshly built images to contain stale
packages. Adding no-cache: true ensures every build pulls the latest
packages.

Signed-off-by: Simo Lin <linsimo.mark@gmail.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@coderabbitai

coderabbitai Bot commented Mar 24, 2026 •

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: dc6b1575-6523-407a-b055-0ae9e3bf278a

📥 Commits

Reviewing files that changed from the base of the PR and between 2dd1f85 and 001ef61.

📒 Files selected for processing (1)
  • .github/workflows/_build-engine-image.yml

📝 Walkthrough

Walkthrough

The Docker engine image build workflow now explicitly disables layer caching by setting no-cache: true on the docker/build-push-action@v7 step. This forces the build process to bypass Docker's cached layers, ensuring a fresh build without leveraging previously cached intermediate results.

Changes

Cohort / File(s) Summary
Docker Build Configuration
.github/workflows/_build-engine-image.yml
Added no-cache: true to the docker/build-push-action step to disable Docker layer caching during image builds.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

ci, docker

Suggested reviewers

  • CatherineSue
  • key4ng
  • XinyueZhang369

Poem

🐰 A rabbit hops through the cache so deep,
"No layers sleep!" the build will leap,
Fresh and clean, no shortcuts take,
Every image baked from scratch we make! 🏗️

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/engine-docker-no-cache

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the ci CI/CD configuration changes label Mar 24, 2026
@slin1237
slin1237 merged commit 9017679 into main Mar 24, 2026
27 of 28 checks passed
@slin1237
slin1237 deleted the fix/engine-docker-no-cache branch March 24, 2026 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI/CD configuration changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant