Repository navigation
fix(ci): disable Docker layer cache for engine image builds - #878
Conversation
The pip install layer for smg-grpc-proto and smg-grpc-servicer was being served from Docker's layer cache even after new versions were published to PyPI, causing freshly built images to contain stale packages. Adding no-cache: true ensures every build pulls the latest packages. Signed-off-by: Simo Lin <linsimo.mark@gmail.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Docker engine image build workflow now explicitly disables layer caching by setting Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Description
Engine docker builds were serving stale pip install layers from Docker cache, causing images to contain old smg-grpc-proto/servicer versions even after new releases.
Changes
.github/workflows/_build-engine-image.yml: Addno-cache: trueto the docker build stepTest Plan
pip freezeshows latest packagesChecklist
Summary by CodeRabbit
Release Notes
No end-user-visible changes in this release. This update modifies internal build infrastructure only.