Skip to content

fix(docker): remove GHA docker cache from engine image builds - #666

Merged
slin1237 merged 1 commit into
mainfrom
slin/docker-cache
Mar 7, 2026
Merged

slin1237 merged 1 commit into
mainfrom
slin/docker-cache

Conversation

@slin1237

@slin1237 slin1237 commented Mar 7, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Remove cache-from: type=gha and cache-to: type=gha,mode=max from the engine image build workflow
  • These builds run on bare-metal self-hosted runners where Docker already caches layers locally
  • The GHA cache (mode=max) was consuming the entire 10GB repo cache budget and evicting other caches

Test plan

  • Verify engine image build still works without GHA cache

Summary by CodeRabbit

  • Chores
    • Updated build pipeline configuration to adjust caching behavior.

The engine image builds run on bare-metal self-hosted runners where
Docker already caches layers locally. The GHA cache (mode=max) was
consuming the entire 10GB repo cache budget and evicting other caches.

Signed-off-by: Wei Gong <simolin@gmail.com>
Signed-off-by: Simo Lin <linsimo.mark@gmail.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@github-actions github-actions Bot added the ci CI/CD configuration changes label Mar 7, 2026
@coderabbitai

coderabbitai Bot commented Mar 7, 2026 •

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: cd5f7739-a6fb-4f58-ac87-63ab80c5d67d

📥 Commits

Reviewing files that changed from the base of the PR and between cb25b2f and 8b88223.

📒 Files selected for processing (1)
  • .github/workflows/_build-engine-image.yml

📝 Walkthrough

Walkthrough

This pull request removes Docker Buildx cache configuration from the build image workflow, eliminating GitHub Actions cache import and export operations (cache-from and cache-to directives) from the build step while preserving all other functionality.

Changes

Cohort / File(s) Summary
Docker Build Caching
.github/workflows/_build-engine-image.yml
Removed GitHub Actions cache-from and cache-to directives from the Build image step, disabling GH Actions cache integration for Docker builds.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • #431 — Adds Docker Buildx cache configuration in the release-docker workflow while this PR removes it from the build-engine-image workflow; may indicate a shift in caching strategy across CI pipelines.

Suggested labels

ci, docker

Suggested reviewers

  • CatherineSue
  • key4ng
  • XinyueZhang369

Poem

🐰 A cache, once kept in Actions' care,
Now bids farewell without a prayer,
The Docker builds will start anew,
No memory of what they knew,
Simplicity in layers true! 🏗️

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch slin/docker-cache

Comment @coderabbitai help to get the list of available commands and usage tips.

@slin1237
slin1237 merged commit fe250af into main Mar 7, 2026
19 of 20 checks passed
@slin1237
slin1237 deleted the slin/docker-cache branch March 7, 2026 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI/CD configuration changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant