Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/workflows/stale.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,6 @@ jobs:
days-before-pr-close: 16
stale-pr-label: 'stale'

# Use creation/update of stale label to track staleness instead of
# updated_at, which GitHub silently bumps for invisible events like
# merge conflict recalculation when main changes.
ignore-pr-updates: true

stale-pr-message: >
Comment on lines 28 to 30

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Don't let bot conflict updates reset the stale timer

Removing ignore-pr-updates puts actions/stale back on GitHub's updated_at clock for both days-before-pr-stale and days-before-pr-close (per the action README), so non-human PR updates now count as activity again. In this repo, .github/mergify.yml:57-86 automatically adds/removes needs-rebase and posts a comment when a PR's conflict status changes, which can happen solely because main moved. Those bot label/comment updates will now restart the 14/16-day timers, so abandoned PRs with conflict churn can stay open indefinitely even when the author has been inactive.

Useful? React with 👍 / 👎.

This pull request has been automatically marked as stale because it
has not had any activity within 14 days. It will be automatically
Expand Down