Skip to content

fix(ci): remove ignore-pr-updates that marks active PRs as stale - #804

Merged
CatherineSue merged 1 commit into
mainfrom
fix/stale-workflow-ignore-updates
Mar 18, 2026
Merged

CatherineSue merged 1 commit into
mainfrom
fix/stale-workflow-ignore-updates

Conversation

@CatherineSue

@CatherineSue CatherineSue commented Mar 18, 2026 •

Copy link
Copy Markdown
Member

Description

Problem

ignore-pr-updates: true in actions/stale uses creation date only, ignoring all activity. This caused active PRs (e.g., #586 with commits yesterday) to be marked stale simply because they were created >14 days ago.

Solution

Remove the flag to use default updated_at-based tracking.

Test Plan

Trigger manually and verify active PRs are not marked stale.

Summary by CodeRabbit

  • Chores
    • Updated stale pull request tracking configuration to consider recent activity and updates when determining staleness status. This ensures pull requests with ongoing changes are not marked as stale based solely on label history.

ignore-pr-updates: true uses creation date only, ignoring all activity.
This caused active PRs (e.g., #586 with commits yesterday) to be marked
stale simply because they were created >14 days ago.

Remove the flag to use default updated_at-based tracking. Old inactive
PRs may dodge the stale label during periods of high main activity
(GitHub bumps updated_at on conflict recalculation), but this is
preferable to false-positive stale labels on active PRs.

Signed-off-by: Chang Su <chang.s.su@oracle.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@CatherineSue
CatherineSue merged commit 17dffdb into main Mar 18, 2026
9 of 11 checks passed
@coderabbitai

coderabbitai Bot commented Mar 18, 2026 •

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: c784758b-c68b-4528-9689-54b13bab2d5b

📥 Commits

Reviewing files that changed from the base of the PR and between ebdf26b and dac3530.

📒 Files selected for processing (1)
  • .github/workflows/stale.yml

📝 Walkthrough

Walkthrough

Removed the ignore-pr-updates: true setting and its explanatory comment from the stale PRs GitHub Actions workflow. This allows PR staleness calculations to account for PR activity and updated_at timestamps rather than exclusively relying on stale label creation/update tracking.

Changes

Cohort / File(s) Summary
Stale Workflow Configuration
.github/workflows/stale.yml
Removed ignore-pr-updates: true setting and associated comment, allowing PR activity to influence staleness decisions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

ci

Suggested reviewers

  • key4ng
  • slin1237
  • XinyueZhang369

Poem

🐰 A bunny bounces with delight,
Staleness rules fade from sight!
Updates now dance, no longer ignored,
Fresh PRs flourish—activity restored! ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/stale-workflow-ignore-updates
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@CatherineSue
CatherineSue deleted the fix/stale-workflow-ignore-updates branch March 18, 2026 06:28
@github-actions github-actions Bot added the ci CI/CD configuration changes label Mar 18, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dac3530a25

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines 28 to 30
stale-pr-label: 'stale'

# Use creation/update of stale label to track staleness instead of
# updated_at, which GitHub silently bumps for invisible events like
# merge conflict recalculation when main changes.
ignore-pr-updates: true

stale-pr-message: >

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Don't let bot conflict updates reset the stale timer

Removing ignore-pr-updates puts actions/stale back on GitHub's updated_at clock for both days-before-pr-stale and days-before-pr-close (per the action README), so non-human PR updates now count as activity again. In this repo, .github/mergify.yml:57-86 automatically adds/removes needs-rebase and posts a comment when a PR's conflict status changes, which can happen solely because main moved. Those bot label/comment updates will now restart the 14/16-day timers, so abandoned PRs with conflict churn can stay open indefinitely even when the author has been inactive.

Useful? React with 👍 / 👎.

smfirmin pushed a commit to smfirmin/smg that referenced this pull request Mar 20, 2026
smfirmin pushed a commit to smfirmin/smg that referenced this pull request Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI/CD configuration changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant