Repository navigation
fix(ci): remove ignore-pr-updates that marks active PRs as stale - #804
Conversation
ignore-pr-updates: true uses creation date only, ignoring all activity. This caused active PRs (e.g., #586 with commits yesterday) to be marked stale simply because they were created >14 days ago. Remove the flag to use default updated_at-based tracking. Old inactive PRs may dodge the stale label during periods of high main activity (GitHub bumps updated_at on conflict recalculation), but this is preferable to false-positive stale labels on active PRs. Signed-off-by: Chang Su <chang.s.su@oracle.com>
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughRemoved the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dac3530a25
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| stale-pr-label: 'stale' | ||
|
|
||
| # Use creation/update of stale label to track staleness instead of | ||
| # updated_at, which GitHub silently bumps for invisible events like | ||
| # merge conflict recalculation when main changes. | ||
| ignore-pr-updates: true | ||
|
|
||
| stale-pr-message: > |
There was a problem hiding this comment.
Don't let bot conflict updates reset the stale timer
Removing ignore-pr-updates puts actions/stale back on GitHub's updated_at clock for both days-before-pr-stale and days-before-pr-close (per the action README), so non-human PR updates now count as activity again. In this repo, .github/mergify.yml:57-86 automatically adds/removes needs-rebase and posts a comment when a PR's conflict status changes, which can happen solely because main moved. Those bot label/comment updates will now restart the 14/16-day timers, so abandoned PRs with conflict churn can stay open indefinitely even when the author has been inactive.
Useful? React with 👍 / 👎.
…-project#804) Signed-off-by: Chang Su <chang.s.su@oracle.com>
…-project#804) Signed-off-by: Chang Su <chang.s.su@oracle.com>
Description
Problem
ignore-pr-updates: true in actions/stale uses creation date only, ignoring all activity. This caused active PRs (e.g., #586 with commits yesterday) to be marked stale simply because they were created >14 days ago.
Solution
Remove the flag to use default updated_at-based tracking.
Test Plan
Trigger manually and verify active PRs are not marked stale.
Summary by CodeRabbit