Skip to content

chore(ci): remove pull request trigger from nightly benchmark workflow - #524

Merged
slin1237 merged 1 commit into
mainfrom
keyang/nightly-trigger
Feb 24, 2026
Merged

slin1237 merged 1 commit into
mainfrom
keyang/nightly-trigger

Conversation

@key4ng

@key4ng key4ng commented Feb 24, 2026 •

Copy link
Copy Markdown
Member

Description

Problem

nightly benchmark workflow shouldn't be triggered by pr

Solution

Changes

Test Plan

Checklist
  • cargo +nightly fmt passes
  • cargo clippy --all-targets --all-features -- -D warnings passes
  • (Optional) Documentation updated

Summary by CodeRabbit

  • Chores
    • Updated workflow scheduling configuration for the nightly benchmark process. The workflow now runs only on scheduled intervals and manual triggers, removing automatic pull request-based execution to streamline continuous integration operations.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@github-actions github-actions Bot added the ci CI/CD configuration changes label Feb 24, 2026
@coderabbitai

coderabbitai Bot commented Feb 24, 2026 •

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fbbb99b and 06879f3.

📒 Files selected for processing (1)
  • .github/workflows/nightly-benchmark.yml

📝 Walkthrough

Walkthrough

The pull request removes the pull_request trigger from the nightly-benchmark GitHub Actions workflow. The workflow will now execute only on schedule and via manual workflow_dispatch invocation, no longer running automatically on pull requests.

Changes

Cohort / File(s) Summary
Workflow Trigger Configuration
.github/workflows/nightly-benchmark.yml
Removed the pull_request trigger that watched e2e_test/** paths and the workflow file itself. Workflow now runs solely on schedule and manual dispatch.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

ci

Suggested reviewers

  • CatherineSue
  • slin1237
  • XinyueZhang369

Poem

🐰 The nightly benchmarks hop away,
No longer checking each PR day,
By schedule alone they'll run so fleet,
A scheduled pulse, forever neat!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch keyang/nightly-trigger

Comment @coderabbitai help to get the list of available commands and usage tips.

@key4ng key4ng closed this Feb 24, 2026
@key4ng key4ng reopened this Feb 24, 2026
@slin1237
slin1237 merged commit e1b0c80 into main Feb 24, 2026
24 of 35 checks passed
@slin1237
slin1237 deleted the keyang/nightly-trigger branch February 24, 2026 05:26
@coderabbitai coderabbitai Bot mentioned this pull request May 27, 2026
2 of 4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI/CD configuration changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants