Repository navigation
ci: remove cancel-merged-pr-tests workflow - #1558
Conversation
The workflow adds two status checks ("Cancel PR Test (SMG/MLX)") to
every merged PR even when it has nothing to cancel, which is more
UI noise than the saved GPU minutes are worth. PR test jobs that
haven't finished by merge time will complete on their own.
Signed-off-by: Chang Su <8605658+CatherineSue@users.noreply.github.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request removes the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Description
Problem
The
Cancel Merged PR Testsworkflow (introduced in #1530, YAML bug fixed in #1556) attaches two status checks —Cancel PR Test (SMG)andCancel PR Test (MLX)— to every merged PR, regardless of whether there was anything to cancel. That UI noise outweighs the actual benefit (cancelling a handful of in-progress PR test jobs after merge).The only viable trigger that avoids surfacing as a PR check would be
pushtomain, but that just moves the noise to main's commit history — same problem, different surface.Solution
Delete the workflow. PR test jobs that haven't completed by merge time will simply run to completion, costing a few minutes of extra GPU time per merged PR. That's an acceptable price for a cleaner PR UI.
The PR-level concurrency on
pr-test-rust.yml/pr-test-mlx.ymlis unaffected — pushing a new commit to an open PR still cancels the prior in-progress run.Changes
.github/workflows/cancel-merged-pr-tests.yml.Test Plan
Cancel PR Test (SMG/MLX)checks will appear on subsequent merged PRs.concurrencybehavior onpr-test-*.yml) is untouched.Checklist
Summary by CodeRabbit