Repository navigation
fix(ci): match probot DCO app check name in Mergify rule - #486
Conversation
Summary of ChangesHello @CatherineSue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where Mergify was failing to comment on DCO (Developer Certificate of Origin) check failures. The problem arose after switching to a new probot DCO app, which reported its check name with different casing. By adjusting the Mergify configuration to match the new, uppercase check name, the automated commenting functionality for DCO failures has been restored, ensuring proper guidance for contributors. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughThis pull request updates the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
The probot DCO app reports its check as "DCO" (uppercase), but the Mergify condition used "dco" (lowercase). Mergify's check-failure condition is case-sensitive for check names, so the rule never fired. Verified by opening a test PR (#485) with an unsigned commit: the DCO check completed with conclusion action_required, but Mergify's Summary showed check-failure = dco as unmatched. Signed-off-by: Chang Su <chang.s.su@oracle.com>
d7da212 to
6578571
Compare
There was a problem hiding this comment.
Code Review
The pull request correctly addresses a case-sensitivity issue in the Mergify configuration. By updating the check name from dco to DCO, the rule will now properly match the status reported by the probot DCO app. This change is necessary for the automated DCO failure comments to function correctly. No other issues were identified in the modified lines.
Description
Problem
After switching from the GitHub Actions DCO workflow to the probot DCO app in #462, the Mergify rule that comments on DCO failures stopped working. The rule condition
check-failure = dconever matches because the probot DCO app reports its check run asDCO(uppercase), and Mergify'scheck-failurecondition is case-sensitive for check names.Solution
Update the Mergify condition from
check-failure = dcotocheck-failure = DCOto match the probot app's actual check name.Changes
.github/mergify.yml: changecheck-failure = dcotocheck-failure = DCOTest Plan
action_required, but Mergify's Summary confirmedcheck-failure = dcowas not matchedChecklist
cargo +nightly fmtpassescargo clippy --all-targets --all-features -- -D warningspassesSummary by CodeRabbit