Skip to content

fix(ci): match probot DCO app check name in Mergify rule - #486

Merged
CatherineSue merged 1 commit into
mainfrom
fix/mergify-dco-check-name
Feb 20, 2026
Merged

CatherineSue merged 1 commit into
mainfrom
fix/mergify-dco-check-name

Conversation

@CatherineSue

@CatherineSue CatherineSue commented Feb 20, 2026 •

Copy link
Copy Markdown
Member

Description

Problem

After switching from the GitHub Actions DCO workflow to the probot DCO app in #462, the Mergify rule that comments on DCO failures stopped working. The rule condition check-failure = dco never matches because the probot DCO app reports its check run as DCO (uppercase), and Mergify's check-failure condition is case-sensitive for check names.

Solution

Update the Mergify condition from check-failure = dco to check-failure = DCO to match the probot app's actual check name.

Changes

  • Update .github/mergify.yml: change check-failure = dco to check-failure = DCO

Test Plan

  • Opened test PR ci(test): verify mergify DCO rule with probot app #485 with an unsigned commit to verify the bug: the DCO probot check reported action_required, but Mergify's Summary confirmed check-failure = dco was not matched
  • After this fix merges, open another test PR with an unsigned commit to confirm Mergify posts the DCO failure comment
Checklist
  • cargo +nightly fmt passes
  • cargo clippy --all-targets --all-features -- -D warnings passes
  • (Optional) Documentation updated

Summary by CodeRabbit

  • Chores
    • Updated CI/CD configuration to improve Developer Certificate of Origin (DCO) check handling in the automated pull request workflow.

@github-actions github-actions Bot added the ci CI/CD configuration changes label Feb 20, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @CatherineSue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where Mergify was failing to comment on DCO (Developer Certificate of Origin) check failures. The problem arose after switching to a new probot DCO app, which reported its check name with different casing. By adjusting the Mergify configuration to match the new, uppercase check name, the automated commenting functionality for DCO failures has been restored, ensuring proper guidance for contributors.

Highlights

  • Mergify DCO Check Fix: The Mergify rule for commenting on DCO failures was updated to correctly match the case-sensitive check name reported by the probot DCO app.
  • Case Sensitivity: The issue stemmed from Mergify's check-failure condition being case-sensitive, requiring the DCO check name to be DCO (uppercase) instead of dco (lowercase).
Changelog
  • .github/mergify.yml
    • Updated the check-failure condition from dco to DCO to correctly identify DCO check failures from the probot app.
Activity
  • The author opened a test PR (ci(test): verify mergify DCO rule with probot app #485) with an unsigned commit to confirm the original bug, verifying that Mergify's check-failure = dco condition was not matched.
  • The author plans to open another test PR after this fix merges to confirm Mergify successfully posts the DCO failure comment.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@coderabbitai

coderabbitai Bot commented Feb 20, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

This pull request updates the .github/mergify.yml configuration file to correct the DCO (Developer Certificate of Origin) check reference from lowercase "dco" to uppercase "DCO" in the Mergify rule condition. This ensures the rule properly matches the correct check name.

Changes

Cohort / File(s) Summary
Mergify Configuration
.github/mergify.yml
Updated DCO check condition casing from "dco" to "DCO" to match the correct check name reference in the Mergify rule.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • slin1237
  • key4ng
  • XinyueZhang369

Poem

🐰 A tiny case from "dco" to "DCO" hops,
The mergify rule now matching where it stops,
Uppercase letters, a config so bright,
One character changed makes the check align right! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: updating the Mergify rule's DCO check reference from lowercase 'dco' to uppercase 'DCO' to match the probot app's check name.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/mergify-dco-check-name

Comment @coderabbitai help to get the list of available commands and usage tips.

The probot DCO app reports its check as "DCO" (uppercase), but the
Mergify condition used "dco" (lowercase). Mergify's check-failure
condition is case-sensitive for check names, so the rule never fired.

Verified by opening a test PR (#485) with an unsigned commit: the DCO
check completed with conclusion action_required, but Mergify's Summary
showed check-failure = dco as unmatched.

Signed-off-by: Chang Su <chang.s.su@oracle.com>
@CatherineSue
CatherineSue force-pushed the fix/mergify-dco-check-name branch from d7da212 to 6578571 Compare February 20, 2026 17:59

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly addresses a case-sensitivity issue in the Mergify configuration. By updating the check name from dco to DCO, the rule will now properly match the status reported by the probot DCO app. This change is necessary for the automated DCO failure comments to function correctly. No other issues were identified in the modified lines.

@CatherineSue
CatherineSue merged commit a2ed182 into main Feb 20, 2026
20 of 21 checks passed
@CatherineSue
CatherineSue deleted the fix/mergify-dco-check-name branch February 20, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI/CD configuration changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant