Skip to content

ci(test): verify mergify DCO rule with probot app - #485

Closed
CatherineSue wants to merge 1 commit into
mainfrom
ci/test-mergify-dco-rule
Closed

CatherineSue wants to merge 1 commit into
mainfrom
ci/test-mergify-dco-rule

Conversation

@CatherineSue

@CatherineSue CatherineSue commented Feb 20, 2026 •

Copy link
Copy Markdown
Member

Description

Test PR — will close after verification.

Testing whether the Mergify check-failure = dco rule fires when the probot DCO app detects a missing Signed-off-by line. This commit is intentionally unsigned.

Ref: investigating why Mergify didn't comment on #484 when DCO was missing.

Summary by CodeRabbit

  • Chores
    • Updated CI/CD configuration for internal testing purposes.

Note: This release contains no user-facing changes or new features.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @CatherineSue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is a temporary, diagnostic change aimed at validating the interaction between Mergify's DCO enforcement rule and the Probot DCO app. It specifically tests whether Mergify accurately identifies and responds to commits that are missing the required Signed-off-by line, addressing previous observations where DCO failures were not properly flagged.

Highlights

  • Mergify DCO Rule Verification: This pull request is a temporary test designed to verify that the Mergify check-failure = dco rule correctly triggers when the Probot DCO app detects a missing Signed-off-by line in a commit. The commit in this PR is intentionally unsigned for this test.
Changelog
  • .github/mergify.yml
    • Added a comment explaining the purpose of this test PR.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@coderabbitai

coderabbitai Bot commented Feb 20, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

A single-line comment was added to the Mergify configuration file for testing DCO check-failure rule behavior with a probot app, marked as temporary for reversion.

Changes

Cohort / File(s) Summary
CI Configuration Test
.github/mergify.yml
Added a single-line comment documenting a temporary test for DCO check-failure rule verification with probot app. No changes to automation rules or behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

ci

Suggested reviewers

  • slin1237
  • key4ng

Poem

🐰 A comment hops in, swift and bright,
Testing rules through the probot night,
Soon it'll vanish, as you said,
But truth rings clear in what we've read! 🌙

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'ci(test): verify mergify DCO rule with probot app' directly relates to the PR objective of testing the Mergify DCO rule with the probot app, and accurately describes the main purpose of the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ci/test-mergify-dco-rule

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the ci CI/CD configuration changes label Feb 20, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces a temporary comment to the Mergify configuration file to test a DCO check-failure rule. This change is intended for verification purposes and will be reverted. The change itself is minimal and serves its stated purpose of testing a specific Mergify rule.

@CatherineSue

Copy link
Copy Markdown
Member Author

Test complete. Confirmed that check-failure = dco does NOT match the probot DCO app's check (named DCO with conclusion action_required). Will fix in a follow-up PR.

@CatherineSue
CatherineSue deleted the ci/test-mergify-dco-rule branch February 20, 2026 17:54
CatherineSue added a commit that referenced this pull request Feb 20, 2026
The probot DCO app reports its check as "DCO" (uppercase), but the
Mergify condition used "dco" (lowercase). Mergify's check-failure
condition is case-sensitive for check names, so the rule never fired.

Verified by opening a test PR (#485) with an unsigned commit: the DCO
check completed with conclusion action_required, but Mergify's Summary
showed check-failure = dco as unmatched.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Chang Su <chang.s.su@oracle.com>
CatherineSue added a commit that referenced this pull request Feb 20, 2026
The probot DCO app reports its check as "DCO" (uppercase), but the
Mergify condition used "dco" (lowercase). Mergify's check-failure
condition is case-sensitive for check names, so the rule never fired.

Verified by opening a test PR (#485) with an unsigned commit: the DCO
check completed with conclusion action_required, but Mergify's Summary
showed check-failure = dco as unmatched.

Signed-off-by: Chang Su <chang.s.su@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI/CD configuration changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant