Repository navigation
ci(test): verify mergify DCO rule with probot app - #485
CatherineSue wants to merge 1 commit into
Conversation
Summary of ChangesHello @CatherineSue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is a temporary, diagnostic change aimed at validating the interaction between Mergify's DCO enforcement rule and the Probot DCO app. It specifically tests whether Mergify accurately identifies and responds to commits that are missing the required Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughA single-line comment was added to the Mergify configuration file for testing DCO check-failure rule behavior with a probot app, marked as temporary for reversion. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
There was a problem hiding this comment.
Code Review
The pull request introduces a temporary comment to the Mergify configuration file to test a DCO check-failure rule. This change is intended for verification purposes and will be reverted. The change itself is minimal and serves its stated purpose of testing a specific Mergify rule.
|
Test complete. Confirmed that |
The probot DCO app reports its check as "DCO" (uppercase), but the Mergify condition used "dco" (lowercase). Mergify's check-failure condition is case-sensitive for check names, so the rule never fired. Verified by opening a test PR (#485) with an unsigned commit: the DCO check completed with conclusion action_required, but Mergify's Summary showed check-failure = dco as unmatched. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Chang Su <chang.s.su@oracle.com>
The probot DCO app reports its check as "DCO" (uppercase), but the Mergify condition used "dco" (lowercase). Mergify's check-failure condition is case-sensitive for check names, so the rule never fired. Verified by opening a test PR (#485) with an unsigned commit: the DCO check completed with conclusion action_required, but Mergify's Summary showed check-failure = dco as unmatched. Signed-off-by: Chang Su <chang.s.su@oracle.com>
Description
Test PR — will close after verification.
Testing whether the Mergify
check-failure = dcorule fires when the probot DCO app detects a missingSigned-off-byline. This commit is intentionally unsigned.Ref: investigating why Mergify didn't comment on #484 when DCO was missing.
Summary by CodeRabbit
Note: This release contains no user-facing changes or new features.