Skip to content

docs(symphony): eighteen more groups are ready, their whole recorded sets replayed with no difference, and batch 4's sets are in - #2883

Merged
slin1237 merged 1 commit into
mainfrom
docs/symphony-readme-batch4-ready
Oct 8, 2026
Merged

slin1237 merged 1 commit into
mainfrom
docs/symphony-readme-batch4-ready

Conversation

@slin1237

@slin1237 slin1237 commented Oct 8, 2026

Copy link
Copy Markdown
Member

What

The models table in crates/symphony/README.md, regenerated from tests/readme.rs (SYMPHONY_WRITE_README=1 cargo test -p smg-symphony --test readme), inside crates/symphony/ only:

  • Eighteen groups move from "replaying the set" to "ready": the whole recorded set of each replayed on main's harness and parser (21d5e44) with no difference beyond bellwether Extract reasoning-parser crate #17's separator bytes (the template's newline the reference keeps in its text), every chunking the harness has.
  • Seventeen groups move from "awaiting fixtures" to "replaying the set": bellwether's batch 4 (Implement QualifiedToolName struct #85, main 32a6f2b6) gives them benchmark-scale sets; the set sizes come from bellwether's README at that commit.
  • Tally: 25 ready, 27 replaying a recorded set, 0 on main awaiting fixtures, 26 pending (was 7, 28, 17, 26).

Replays

Group Cases Bitwise Separators only Listed (#16) Differences
glm-5.3-flash 54,193 54,191 0 2 0
qwen-agentworld-35b-a3b 54,193 7 54,184 2 0
qwen-drive-1.0-4b 54,179 7 54,170 2 0
qwen3.5-2b 41,360 40,390 969 1 0
qwen3.5-9b 54,179 7 54,170 2 0
qwen3.5-27b 54,179 7 54,170 2 0
qwen3.5-35b-a3b 54,179 7 54,170 2 0
qwen3.6-27b 54,193 7 54,184 2 0
qwen3.6-35b-a3b 54,193 7 54,184 2 0
qwen3.8-2.4t-a95b 54,183 0 54,182 1 0
qwen3.8-27b 54,193 7 54,184 2 0
qwen3.8-flash-next 54,193 7 54,184 2 0
qwen2.5-7b-instruct-1m 41,533 40,530 1,002 1 0
qwen3-vl-8b-instruct 41,533 40,530 1,002 1 0
qwen3-vl-8b-thinking 54,418 0 54,416 2 0
qwen3-vl-30b-a3b-instruct 41,533 40,530 1,002 1 0
qwen3-vl-235b-a22b-thinking 54,418 0 54,416 2 0
webworld-32b 54,418 7 54,409 2 0

"Separators only" is bellwether #17's class: the reference keeps the template's newline in its text, the parser does not, and the two agree once it is trimmed; "listed" are the two bellwether #16 probes a table reads as its own markers. Logs: the queue's whole_queue.log and one whole-<slug>.log per group.

Gates

By exit code (.claude/symphony/gates.sh): fmt, clippy -D warnings, test (307 lib, 10 fixture, 7 contract, 5 README), doc, width, codespell, all 0.

Not in this PR

Merge

Squash under rule 25 (rule 18 does not apply: data only). Subject: the PR title plus (#<n>). Body:

Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
Co-authored-by: Chang Su <8605658+CatherineSue@users.noreply.github.com>

…sets replayed with no difference, and batch 4's sets are in

The whole recorded set of eighteen groups replayed on main's harness and
parser with no difference beyond bellwether #17's separator bytes:
glm-5.3-flash, qwen-agentworld-35b-a3b, qwen-drive-1.0-4b, qwen3.5-2b,
qwen3.5-9b, qwen3.5-27b, qwen3.5-35b-a3b, qwen3.6-27b, qwen3.6-35b-a3b,
qwen3.8-2.4t-a95b, qwen3.8-27b, qwen3.8-flash-next, qwen2.5-7b-instruct-1m,
qwen3-vl-8b-instruct, qwen3-vl-8b-thinking, qwen3-vl-30b-a3b-instruct,
qwen3-vl-235b-a22b-thinking and webworld-32b, so their rows say ready.
bellwether's batch 4 (#85) gives seventeen groups with a table their
benchmark-scale sets, so their rows move from awaiting fixtures to
replaying the set, with the set sizes from bellwether's README at
32a6f2b6. The table now reads 25 ready, 27 replaying, 0 awaiting
fixtures, 26 pending.

Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
Co-authored-by: Chang Su <8605658+CatherineSue@users.noreply.github.com>
@slin1237
slin1237 requested a review from CatherineSue as a code owner October 8, 2026 09:09
@github-actions github-actions Bot added documentation Improvements or additions to documentation tests Test changes symphony crates/symphony: the unified output parser labels Oct 8, 2026
@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Team
  • Run ID: 02910525-1e9e-497c-8b98-2aec180dcfad
📥 Commits

Reviewing files that changed from the base of the PR and between 21d5e44 and cef4604.

📒 Files selected for processing (2)
  • crates/symphony/README.md
  • crates/symphony/tests/readme.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Documentation
    • Updated model checkpoint counts and statuses, including newly recorded test sets.
  • Tests
    • Updated the expected model groups and their readiness statuses to match the latest records.

Walkthrough

The test inventory and README now report updated recorded set counts and checkpoint statuses for model groups. The README summary reports 25 ready, 27 replaying, none awaiting fixtures, and 26 pending.

Changes

Model checkpoint inventory

Layer / File(s) Summary
Update model checkpoint inventory
crates/symphony/tests/readme.rs, crates/symphony/README.md
The test inventory and README table now include recorded set counts for additional groups and updated Replaying or Ready statuses. The README summary reflects the updated totals.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: key4ng

Merge Risk: ⚪ Minimal · up to cef46

The inventory and README are consistent, and no concrete defect is established. The reported replay results are not independently verified by the checked-in tests, but no actionable merge blocker is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the two main changes: eighteen groups became ready, and batch 4 recorded sets became available. It is specific and related to the changeset, although it is longer than …
Description check ✅ Passed The description directly explains the README and test updates, replay results, fixture changes, validation gates, and resulting tallies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@claude

claude Bot commented Oct 8, 2026

Copy link
Copy Markdown

👋 The PR description doesn't fully follow
PULL_REQUEST_TEMPLATE.md:

  • Missing header: ## Description
  • Missing header: ### Problem
  • Missing header: ### Solution
  • Missing header: ## Changes
  • Missing header: ## Test Plan

Please update the PR description so reviewers have the context they need.

@coderabbitai
coderabbitai Bot requested a review from key4ng October 8, 2026 09:12

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data-only change, checked against its sources:

  • Set sizes: all 17 new set values match the parse-case counts in bellwether's README at 32a6f2b6 (batch 4, #85). step3 was recorded with 0 parse cases, so it stays pending. The existing groups' rows did not change upstream, so the sets already listed are still current.
  • Status moves: the 18 groups moved to Ready are exactly the 18 in the PR's replay table. In each row, bitwise + separators-only + listed adds up to the recorded set size. Separators-only is the harness's accepted bellwether #17 class.
  • Tally: 7+18=25 ready, 28−18+17=27 replaying, 0 awaiting, 26 pending, 78 total.
  • README: all 78 generated rows match GROUPS for slug, set and status. The every_status_has_what_it_claims checks hold.

🔴 0 · 🟡 0 · 🟣 0

@hello-alexmcc hello-alexmcc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule-17 review of #2883 at cef4604: approve. I checked the README's numbers against their sources.

  • Tally: 25 ready, 27 replaying, 0 awaiting fixtures and 26 pending make 78, as 7, 28, 17 and 26 did before.
  • Eighteen to "ready": they are exactly the description's eighteen replays. In each, bitwise plus separator-only plus listed cases add up to the group's cases, with 0 differences. Their case counts in the table are unchanged.
  • Seventeen to "replaying the set": they are exactly batch 4's groups (#85, bellwether main 32a6f2b6) except step3, which has no table and stays pending. Each one's case count equals the parse cases in bellwether's README at that commit: 17 of 17.

Gates. I ran them at cef4604 on main 21d5e44, with Rust 1.98.0, its own target dir and -j 2; each exited 0:

  • cargo +nightly fmt -p smg-symphony --check
  • cargo clippy -p smg-symphony --all-targets --all-features -- -D warnings
  • cargo test -p smg-symphony: 307 lib, 10 fixture, 7 contract and 5 README tests
  • RUSTDOCFLAGS="-D warnings" cargo doc -p smg-symphony --no-deps

Rule 17:

  • Fixture ids: none changed.
  • Protected paths: the crate's README and its README test.
  • Trailers: the author's Signed-off-by and a Co-authored-by, and no AI trailer.
  • Threads: none.

I didn't re-run the eighteen whole-set replays; the figures above are the description's, checked for consistency.

@slin1237
slin1237 merged commit 4014bff into main Oct 8, 2026
38 checks passed
@slin1237
slin1237 deleted the docs/symphony-readme-batch4-ready branch October 8, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation symphony crates/symphony: the unified output parser tests Test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants