Repository navigation
feat(protocols): add the z.ai (GLM) provider profile #2634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7077fe2
feat(protocols): add the z.ai (GLM) provider profile
hello-alexmcc 7b92a4b
fix(protocols): check both reasoning-effort spellings and tidy the bu…
hello-alexmcc 15039d0
fix(protocols): pin the GLM-5 thinking rules and defaults to GLM-5 ids
hello-alexmcc 60e53ca
fix(protocols): pin the enabled-only thinking rules to the GLM-5.3 se…
hello-alexmcc ac9bb5c
fix(protocols): reject thinking.type adaptive for every z.ai model
hello-alexmcc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Nit: The struct's doc comment a few lines up still says "The
thinkingobject shared by the Kimi and MiniMax chat APIs" — with this z.ai-specific field added, the enumeration is stale. Consider updating it to mention z.ai (e.g. "shared by the Kimi, MiniMax and z.ai chat APIs") so the doc doesn't rot as soon as this merges.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 20b33bc: "shared by the Kimi, MiniMax and z.ai chat APIs".