Repository navigation
fix(ci): repair crate publication order - #1940
Conversation
Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
📝 WalkthroughWalkthroughThe release workflow now uses expanded triggers, revised crate publishing tiers, and sequential publication of ChangesCrate release and version alignment
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Workflow
participant Tier1
participant Tier2
participant Tier3
participant Tier4
participant Registry
Workflow->>Tier1: start crate publishing
Tier1->>Registry: publish Tier 1 crates
Tier1->>Tier2: complete
Tier2->>Registry: publish Tier 2 crates
Tier2->>Tier3: complete
Tier3->>Registry: publish llm-multimodal
Tier3->>Tier4: complete
Tier4->>Registry: publish smg
Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Code Review
This pull request bumps the version of smg-data-connector to 2.3.3 in both the workspace and package Cargo.toml files. It also adds platform-specific conditional compilation attributes (#[cfg(target_os = "linux")]) to Linux-only imports in the test module of assemble.rs to prevent compilation warnings or errors on other operating systems. Additionally, the smg-mm-rdma crate is added to the release version check script. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
👋 The PR description doesn't fully follow
Please update the PR description so reviewers have the context they need. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/release-crates.yml:
- Line 83: Update the actions/checkout step in the publish job to disable
credential persistence by configuring its persist-credentials option to false,
ensuring the local action cannot access the GitHub token through Git
configuration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 39fe7ada-9dbe-4ee0-9c22-d1aebb632bad
📒 Files selected for processing (5)
.github/workflows/release-crates.ymlCargo.tomlcrates/data_connector/Cargo.tomlmodel_gateway/src/routers/grpc/multimodal/assemble.rsscripts/check_release_versions.sh
| needs: tier2 | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v7 |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
Do not persist the checkout credential.
The publish job checks out repository code and then invokes a local action; any command executed during that path can read the persisted GitHub token from Git configuration. Disable persistence.
Proposed fix
- - uses: actions/checkout@v7
+ - uses: actions/checkout@v7
+ with:
+ persist-credentials: false📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - uses: actions/checkout@v7 | |
| - uses: actions/checkout@v7 | |
| with: | |
| persist-credentials: false |
🧰 Tools
🪛 zizmor (1.26.1)
[warning] 83-83: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false
(artipacked)
[error] 83-83: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy)
(unpinned-uses)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/release-crates.yml at line 83, Update the actions/checkout
step in the publish job to disable credential persistence by configuring its
persist-credentials option to false, ensuring the local action cannot access the
GitHub token through Git configuration.
Source: Linters/SAST tools
Description
The v1.8.0 crate release failed when publishing
smgbecause its unpublishedsmg-mm-rdmadependency was missing from the release workflow. The dependency audit also found crates in invalid tiers and the publishablesmg-clientcrate absent from the workflow.Failed run: https://github.com/lightseekorg/smg/actions/runs/29648333758
Changes
smg-mm-rdmato tier 1 and release-version tracking.smg-mcpto tier 1; movesmg-wasmandllm-tokenizerto tier 2.smg-clientto tier 2.llm-multimodalin tier 3 andsmgin tier 4.data-connectorfrom 2.3.2 to 2.3.3 so the changes merged after the v1.8.0 release branch are published before retryingsmg.Test Plan
./scripts/check_release_versions.sh v1.7.0cargo publish --dry-run -p smg-mm-rdma --allow-dirtycargo publish --dry-run -p data-connector --allow-dirtycargo +nightly fmt --allcargo clippy --workspace --all-targets --all-features -- -D warningscargo testgit diff --checkSummary by CodeRabbit
Release Management
Bug Fixes
Maintenance