Repository navigation
fix(multimodal): gate shm-namespace test to Linux - #1849
Conversation
…reads /proc + /dev/shm) Signed-off-by: Simo Lin <linsimo.mark@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe test module for ChangesLinux test gating
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the conditional compilation attribute for the local_shm_namespace_id_resolves_on_linux test in multimodal.rs from #[cfg(unix)] to #[cfg(target_os = "linux")] to ensure it only runs on Linux environments. There are no review comments to address, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
👋 The PR description doesn't fully follow PULL_REQUEST_TEMPLATE.md:
Please update the PR description so reviewers have the context they need. |
Summary
The
local_shm_namespace_id_resolves_on_linuxtest was gated with#[cfg(unix)], but it reads Linux-only paths (/proc/sys/kernel/random/boot_idand/dev/shm). On macOS dev hosts (which are alsounix), the test fails because those paths don't exist.Re-gated the test to
#[cfg(target_os = "linux")]so it only runs on Linux where the required paths exist.Test plan
cargo build -p smg- cleancargo test -p smg --lib routers::grpc::multimodal- 19 passed, test correctly skipped on macOScargo clippy -p smg --all-targets- clean (only pre-existing warnings)CI (Linux) behavior unchanged - the test will continue to run and pass on Linux CI.
Summary by CodeRabbit