ci: pin sglang to v0.5.10rc0 for proto compat - #1005
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughCI install now pins SGLang to prerelease 0.5.10rc0 via pip with --prerelease=allow; small code changes update a ZMQ import path and make GetLoads timestamp generation explicitly UTC-aware; ruff config adds an UP017 ignore for grpc_servicer/**. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the ci_install_sglang.sh script to pin the sglang[all] installation to version 0.5.10rc0. This change is a temporary measure to include the smg_grpc_servicer migration and resolve issues with removed proto types until a stable version is released. I have no feedback to provide.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@grpc_servicer/smg_grpc_servicer/sglang/request_manager.py`:
- Around line 38-39: The project currently imports get_zmq_socket from
sglang.srt.utils.network in request_manager.py but pyproject.toml allows
sglang>=0.5.9 which lacks that module layout; update the dependency to
sglang>=0.5.10rc0 in pyproject.toml or add a compatibility fallback in
request_manager.py that first tries "from sglang.srt.utils.network import
get_zmq_socket" and, on ImportError, falls back to the older path (e.g., "from
sglang.srt.utils import get_zmq_socket" or the correct legacy location); adjust
imports near get_or_create_event_loop and kill_process_tree usage accordingly so
get_zmq_socket is always defined.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: cbf6f199-b500-4ade-8797-27c9939eaad8
📒 Files selected for processing (3)
grpc_servicer/smg_grpc_servicer/sglang/request_manager.pygrpc_servicer/smg_grpc_servicer/sglang/servicer.pyruff.toml
The old sglang built-in grpc_server.py references EmbedError/EmbedComplete proto types that were removed in our proto cleanup. v0.5.10rc0 includes sgl-project/sglang#20478 which migrates to smg_grpc_servicer. TODO: revert to "sglang[all]" once a stable >= 0.5.10 is released. Signed-off-by: Chang Su <chang.s.su@oracle.com>
sglang 0.5.10rc0 depends on flash-attn-4>=4.0.0b4 which is a pre-release. uv requires --prerelease=allow to resolve pre-release dependencies. Signed-off-by: Chang Su <chang.s.su@oracle.com>
…onfig datetime.UTC was added in Python 3.11 but grpc_servicer declares requires-python >= 3.10. Replace with timezone.utc and add ruff per-file-ignore for UP017 on grpc_servicer/ to prevent pyupgrade from reverting to 3.11+ syntax. Signed-off-by: Chang Su <chang.s.su@oracle.com>
get_zmq_socket was moved from sglang.srt.utils to sglang.srt.utils.network in newer sglang versions. Signed-off-by: Chang Su <chang.s.su@oracle.com>
get_zmq_socket moved to sglang.srt.utils.network in 0.5.10rc0. The old sglang>=0.5.9 constraint allowed versions that lack this path. Signed-off-by: Chang Su <chang.s.su@oracle.com>
|
Hi @CatherineSue, this PR has merge conflicts that must be resolved before it can be merged. Please rebase your branch: git fetch origin main
git rebase origin/main
# resolve any conflicts, then:
git push --force-with-lease |
sglang v0.5.10rc0 no longer trims stop sequences in streaming for Harmony models — behavior now matches the class default (STOP_SEQUENCE_TRIMMED = False). Remove the sglang-specific override. Signed-off-by: Chang Su <chang.s.su@oracle.com>
bb214b5 to
40c439d
Compare
Description
Problem
CI installs
sglang[all]from PyPI which gets v0.5.9. That version has the old built-ingrpc_server.pythat referencesEmbedError/EmbedCompleteproto types — types we removed in #1001. This causesAttributeErrorduring gRPC warmup in e2e tests.Solution
Pin to
sglang[all]==0.5.10rc0which includes sgl-project/sglang#20478 — the migration from built-in gRPC server tosmg_grpc_servicer.A TODO comment marks this for revert once a stable >= 0.5.10 is released.
Changes
sglang[all]==0.5.10rc0inscripts/ci_install_sglang.shTest Plan
Checklist
cargo +nightly fmtpassescargo clippy --all-targets --all-features -- -D warningspassesSummary by CodeRabbit
Chores
Bug Fixes