Repository navigation
[gRPC] Extract gRPC servicer into standalone package - #20478
Merged
Merged
Conversation
Move gRPC server implementation (servicer, request manager, health servicer, scheduler launcher, utils) into the smg-grpc-servicer package. Replace grpc_server.py with a thin import shim that delegates to the external package. Update all pyproject files to depend on smg-grpc-servicer[sglang] and remove now-transitive grpc dependencies. Signed-off-by: Simo Lin <linsimo.mark@gmail.com>
slin1237
requested review from
CatherineSue,
Fridge003,
ispobock and
merrymercy
as code owners
March 12, 2026 23:54
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
github-actions
Bot
added
dependencies
Collaborator
Author
|
/tag-run-ci-label |
Collaborator
Author
|
/tag-and-rerun-ci |
sglang dev version (0.0.0.dev1) doesn't satisfy the sglang>=0.5.9 constraint in the [sglang] extra. The base package includes all servicer code; sglang is already present at runtime. Signed-off-by: Simo Lin <linsimo.mark@gmail.com>
5 tasks
Wangzheee
pushed a commit
to Wangzheee/sglang
that referenced
this pull request
Mar 21, 2026
Signed-off-by: Simo Lin <linsimo.mark@gmail.com>
CatherineSue
added a commit
to smg-project/smg
that referenced
this pull request
Mar 31, 2026
The old sglang built-in grpc_server.py references EmbedError/EmbedComplete proto types that were removed in our proto cleanup. v0.5.10rc0 includes sgl-project/sglang#20478 which migrates to smg_grpc_servicer. TODO: revert to "sglang[all]" once a stable >= 0.5.10 is released. Signed-off-by: Chang Su <chang.s.su@oracle.com>
CatherineSue
added a commit
to smg-project/smg
that referenced
this pull request
Apr 1, 2026
The old sglang built-in grpc_server.py references EmbedError/EmbedComplete proto types that were removed in our proto cleanup. v0.5.10rc0 includes sgl-project/sglang#20478 which migrates to smg_grpc_servicer. TODO: revert to "sglang[all]" once a stable >= 0.5.10 is released. Signed-off-by: Chang Su <chang.s.su@oracle.com>
JustinTong0323
pushed a commit
to JustinTong0323/sglang
that referenced
this pull request
Apr 7, 2026
Signed-off-by: Simo Lin <linsimo.mark@gmail.com>
3 of 5 tasks
Chronostasys
pushed a commit
to MindLab-Research/sglang
that referenced
this pull request
Aug 24, 2026
Signed-off-by: Simo Lin <linsimo.mark@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grpc_server.pywith a thin import shim that delegates to the external packageTest plan
python -m sglang.launch_server --grpc-modestarts successfully