Repository navigation
docs: document request body streaming and upstream HTTP/2 - #47
Merged
Merged
Conversation
Add concepts/performance/request-streaming.md: per-request stream-vs-buffer decision (smg-project/smg#2198, #2286, #2202, #2355), stall and size aborts (#2201), memory bounds and response relays (#2232, #2237, #2138, #2097, #2136, #2488), upstream HTTP/2 and pooling (#2155, #2407, #2218, #2162). Fix retries.md for v1.11: attempt counting, streamed and terminal exclusions, capacity pushback (#2163), per-worker overrides, metrics and PromQL. Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
|
Warning Review limit reachedNext included review available in 39 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Your 64 included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Comment |
This was referenced Sep 24, 2026
…ing details - smg_worker_retry_backoff_seconds is exported as a summary (no bucket matcher applies), so query its quantile series instead of histogram_quantile over _bucket - In regular HTTP mode an upstream timeout is a 500, not a 504; PD transport failures are 502 - An out-of-range --retry-jitter-factor fails validation at startup instead of being clamped - Per-worker retry fields: describe why no per-model policy is created - Use smg launch in every example - A declared Content-Length over --max-payload-size gets a plain 413 before routing; the worker-response cap applies in regular HTTP mode - Client disconnects cancel the upstream request (an HTTP/2 stream is reset, not the shared connection) - HTTP/2 negotiation: pinning and the flag skip only the version probe, and http2/smg_worker_http2 reflect the registration-time choice Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.10.0 reworked how the HTTP router handles request bodies and upstream connections.
--stream-request-bodies-overflag from pre-release builds was removed before v1.10.0 shipped.None of this was documented. The retries page also had several errors:
--retry-max-retriesincludes the first attempt.Changes
concepts/performance/request-streaming.md("Request Streaming and Upstream Connections"):reasonmetric label.TCP_NODELAY.http_pooloverrides, and the one-shot resend.concepts/reliability/retries.md:resilienceretry fields are documented as having no effect in v1.11.0. See docs(api): document the full worker spec for the worker management API #43: registration never stores them on the worker, so no per-model retry policy is created.Verification
v1.11.0(3be823a7):routers/common/body_policy.rs,routers/http/{router,request_stream,request_body}.rs,routers/common/request_lease.rsworker/http_client.rs,workflow/steps/local/detect_connection.rscrates/external_router/src/{retry,retry_config,sse,header_utils}.rs,workflow/steps/shared/register.rsmain.rsandobservability/metrics.rspnpm lint,pnpm check(0 errors), andpnpm buildpass.sticky-sessions.md(docs(routing): document sticky sessions and routing headers #42) andoverload-protection.md(docs(reliability): document worker overload protection and load monitoring #37).wrangler pages dev.This is one of a series of docs PRs that bring the site up to smg v1.11.0, one per area.
🤖 Generated with Claude Code