feat(ice): add Last Value Persistence (LVP) for off-market hours #4506
+171
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add LVP_HEARTBEAT_INTERVAL config (default 30s) - Emit heartbeat events from NetDania StreamingClient on interval - Add updateTTL method to extend cache TTLs for active subscriptions - Track current subscriptions in transport for TTL refresh - Start/stop heartbeat on connect/disconnect events This ensures cached prices remain available during off-market hours when no price updates are received from the data provider, similar to the TP/ICAP EA implementations.
🦋 Changeset detectedLatest commit: b7381b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
FionnL
force-pushed
the
feature/ice-lvp
branch
from
928f1c7 to
2824404
Compare
- Add ONHEARTBEAT event to NetDania jsApi (fires when internal heartbeat succeeds) - Modify heartBeatTask to emit ONHEARTBEAT event confirming DP connection is alive - Update StreamingClient to listen for native heartbeat instead of using setInterval - Remove LVP_HEARTBEAT_INTERVAL config (no longer needed) - Update unit tests to verify event-driven heartbeat behavior This approach is more reliable because it confirms the actual data provider connection is healthy, rather than just running a local timer. The heartbeat automatically stops when the connection is lost (ONDISCONNECTED).
FionnL
force-pushed
the
feature/ice-lvp
branch
from
2824404 to
4611859
Compare
FionnL
force-pushed
the
feature/ice-lvp
branch
from
1401039 to
5d788cb
Compare
FionnL
force-pushed
the
feature/ice-lvp
branch
from
d5a0313 to
b7381b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #ISSUE_NUMBER_GOES_HERE
Description
This ensures cached prices remain available during off-market hours when no price updates are received from the data provider, similar to the TP/ICAP EA implementations.
Changes
Added Last Value Persistence (LVP) to the ICE adapter by implementing a configurable heartbeat interval (LVP_HEARTBEAT_INTERVAL, default 30s) that periodically extends cache TTLs for all active subscriptions, ensuring cached prices remain available during off-market hours when no price updates are received from the data provider.
Steps to Test
Quality Assurance
infra-k8sconfiguration file.adapter-secretsconfiguration file.test-payload.jsonfile with relevant requests.feature/x,chore/x,release/x,hotfix/x,fix/x) or is created from Jira.