Skip to content

Update logging for beholder protos registration for clearer monitoring. #2180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update logging for beholder protos registration for clearer monitoring. #2180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions framework/components/dockercompose/chip_ingress_set/protos.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@ func checkSchemaExists(registryURL, subject string) (int, bool) {
var err error
resp, err = http.Get(url)
if err != nil {
framework.L.Debug().Msgf("Failed to check schema existence for %s: %v", subject, err)
framework.L.Error().Msgf("Failed to check schema existence for %s: %v", subject, err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use Warn()?

return err
}

Expand All @@ -569,13 +569,18 @@ func checkSchemaExists(registryURL, subject string) (int, bool) {
}

return nil
}, retry.Attempts(10), retry.Delay(100*time.Millisecond), retry.DelayType(retry.BackOffDelay), retry.OnRetry(func(n uint, err error) {
framework.L.Debug().Str("attempt/max", fmt.Sprintf("%d/%d", n, maxAttempts)).Msgf("Retrying to check schema existence for %s: %v", subject, err)
}), retry.RetryIf(func(err error) bool {
return isRetryableError(err)
}))
}, retry.Attempts(10),
retry.Delay(500*time.Millisecond),
retry.DelayType(retry.BackOffDelay),
retry.OnRetry(func(n uint, err error) {
framework.L.Warn().Str("attempt/max", fmt.Sprintf("%d/%d", n, maxAttempts)).Msgf("Retrying to check schema existence for %s: %v", subject, err)
}),
retry.RetryIf(func(err error) bool {
return isRetryableError(err)
}))

if existErr != nil {
framework.L.Warn().Str("subject", subject).Err(existErr).Msgf("All %d attempts to check schema existence failed. Last error: %v", maxAttempts, existErr)
return 0, false
}

Expand Down
Loading