Skip to content

Conversation

chudilka1
Copy link
Contributor

@chudilka1 chudilka1 commented Oct 6, 2025


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The adjustments enhance error visibility during schema existence checks in a microservice framework. By escalating log levels from Debug to Error or Warn, it aids in identifying and reacting to issues more swiftly, especially in production environments where debug logs might be suppressed.

What

  • framework/components/dockercompose/chip_ingress_set/protos.go
    • Changed log level from Debug to Error when failing to check schema existence, making it more visible.
    • Changed log level from Debug to Warn when retrying to check schema existence, increasing the visibility of retry attempts.
    • Added a warning log after all attempts to check schema existence fail, providing immediate feedback on failure after retry exhaustion.

@chudilka1 chudilka1 requested a review from a team as a code owner October 6, 2025 16:02
Copy link

github-actions bot commented Oct 6, 2025

👋 chudilka1, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@chudilka1 chudilka1 force-pushed the CRE-1023-beholder-optimizations branch from afed053 to bc75afc Compare October 6, 2025 16:06
resp, err = http.Get(url)
if err != nil {
framework.L.Debug().Msgf("Failed to check schema existence for %s: %v", subject, err)
framework.L.Error().Msgf("Failed to check schema existence for %s: %v", subject, err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use Warn()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants