Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken pip install #13

Closed
wants to merge 1 commit into from
Closed

Fix broken pip install #13

wants to merge 1 commit into from

Conversation

stweil
Copy link

@stweil stweil commented Dec 6, 2023

No description provided.

Signed-off-by: Stefan Weil <[email protected]>
@stweil
Copy link
Author

stweil commented Dec 6, 2023

pip install . fails with recent versions of Python3 / pip. See discussion at OCR-D/ocrd_all#400.

This patch provides a fast fix. I think a better one would integrate metadata from setup.cfg into pyproject.toml.

@kba
Copy link

kba commented Dec 6, 2023

pip install . fails with recent versions of Python3 / pip. See discussion at OCR-D/ocrd_all#400.

This is what I would have done, but ...

This patch provides a fast fix. I think a better one would integrate metadata from setup.cfg into pyproject.toml.

... this is what I would have recommended :-)

So agree, we should move most if not all the metadata from setup.cfg to the [project] table of pyproject.toml.

@bertsky
Copy link
Member

bertsky commented Dec 7, 2023

Wow. That issue really caught me by surprise. We were following quite recent guidelines regarding modernized packaging, only to find out that this has already become unsupported by setuptools now.

Official documentation on this is still poor:

So I now understand that because we do need dynamic version, we cannot use setup.cfg anymore! (I believe this issue will affect lots of other packages we manage, too.)

Thanks for the workaround, @stweil! It seems to work, but I would also prefer migrating from setup.cfg. So let's keep this open for current ocrd_all, but I'll draft a new PR along those lines.

@bertsky
Copy link
Member

bertsky commented Jan 22, 2024

superseded by #14

@bertsky bertsky closed this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants