-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken pip install #13
Conversation
Signed-off-by: Stefan Weil <[email protected]>
This patch provides a fast fix. I think a better one would integrate metadata from setup.cfg into pyproject.toml. |
This is what I would have done, but ...
... this is what I would have recommended :-) So agree, we should move most if not all the metadata from |
Wow. That issue really caught me by surprise. We were following quite recent guidelines regarding modernized packaging, only to find out that this has already become unsupported by setuptools now. Official documentation on this is still poor:
So I now understand that because we do need dynamic version, we cannot use setup.cfg anymore! (I believe this issue will affect lots of other packages we manage, too.) Thanks for the workaround, @stweil! It seems to work, but I would also prefer migrating from setup.cfg. So let's keep this open for current ocrd_all, but I'll draft a new PR along those lines. |
superseded by #14 |
No description provided.