Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests #16

Closed
rue-a opened this issue Jan 12, 2024 · 4 comments
Closed

Update tests #16

rue-a opened this issue Jan 12, 2024 · 4 comments
Assignees
@bertsky

Comments

@rue-a
Copy link
Collaborator

rue-a commented Jan 12, 2024

The tests have to be updated.
@rue-a
Copy link
Collaborator Author

rue-a commented Jan 12, 2024

I updated the test data. It turns out the tests are failing due to some issue with installing the package. @bertsky can you look into this?

@bertsky bertsky self-assigned this Jan 12, 2024
@bertsky
Copy link
Member

bertsky commented Jan 12, 2024

I believe this is really what we already discussed in 13. Merging #14 should suffice.

@bertsky
Copy link
Member

bertsky commented Jan 12, 2024

Now as you can see CI fails because the tests are gone. In fact, your 0241430 broke them. (Should be pytest textract2page/tests now.)

What was the reasoning here? IMO tests should not be part of the Python distribution.

@rue-a
Copy link
Collaborator Author

rue-a commented Jan 15, 2024

Not sure why I had them there. Moved them upwards and fixed the issues.

@rue-a rue-a closed this as completed Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bertsky bertsky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rue-a @bertsky