Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature oAuth2 #6

Merged
merged 11 commits into from
May 2, 2019
Merged

Feature oAuth2 #6

merged 11 commits into from
May 2, 2019

Conversation

upwebdesign
Copy link
Contributor

@slakbal Im opening this pull request to build upon. Let me know if you have questions.

Add distribution xml file for phpunit to be duplicated and modified for your environment. Ignore duplicated phpunit.xml file for api sensitive information.
This is now a Post operation. Add parameters as body data. Expect a JSON response. If we dont have an access object, use basic authentication according to Gotowebinar specifications. Also cleaned up the file a little bit.
@slakbal
Copy link
Owner

slakbal commented Apr 8, 2019

Hi @upwebdesign so sorry was really hectic on my side. I will review tonight and test also.

regards

@slakbal slakbal merged commit 0e6d738 into slakbal:master May 2, 2019
@slakbal
Copy link
Owner

slakbal commented May 2, 2019

@upwebdesign merged the PR but not releasing yet the new version. Going over everything first.

@upwebdesign
Copy link
Contributor Author

@slakbal ok, great, let me know when you think this is ready to go for some real testing.

@upwebdesign upwebdesign mentioned this pull request Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants