-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature oAuth2 #6
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add distribution xml file for phpunit to be duplicated and modified for your environment. Ignore duplicated phpunit.xml file for api sensitive information.
This is now a Post operation. Add parameters as body data. Expect a JSON response. If we dont have an access object, use basic authentication according to Gotowebinar specifications. Also cleaned up the file a little bit.
Hi @upwebdesign so sorry was really hectic on my side. I will review tonight and test also. regards |
@upwebdesign merged the PR but not releasing yet the new version. Going over everything first. |
@slakbal ok, great, let me know when you think this is ready to go for some real testing. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@slakbal Im opening this pull request to build upon. Let me know if you have questions.